Closed Bug 1305993 Opened 3 years ago Closed 3 years ago

Intermittent dom/security/test/hsts/browser_hsts-priming_main.js | Test timed out -

Categories

(Core :: DOM: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kmckinley)

References

Details

(Keywords: intermittent-failure, Whiteboard: [domsecurity-intermittent])

Attachments

(1 file)

Blocks: 1246540
Component: DOM → DOM: Security
Flags: needinfo?(kmckinley)
Breaking up the tests to prevent the timeout occurring.
Assignee: nobody → kmckinley
Status: NEW → ASSIGNED
Flags: needinfo?(kmckinley)
Comment on attachment 8798762 [details]
Bug 1305993 - Break tests up to avoid timeouts

https://reviewboard.mozilla.org/r/84174/#review82790

::: dom/security/test/hsts/browser_hsts-priming_allow_active.js:14
(Diff revision 1)
> +add_task(function*() {
> +  //jscs:enable
> +  Services.obs.addObserver(Observer, "console-api-log-event", false);
> +  Services.obs.addObserver(Observer, "http-on-examine-response", false);
> +  registerCleanupFunction(do_cleanup);
> +  requestLongerTimeout(4);

Do you still ned the requestLongerTimeOut(4) in every *.js file?
Comment on attachment 8798762 [details]
Bug 1305993 - Break tests up to avoid timeouts

It seems I still can't operate mozreview - anyway, r=me
Attachment #8798762 - Flags: review?(ckerschb) → review+
Priority: -- → P3
Whiteboard: [domsecurity-intermittent]
Comment on attachment 8798762 [details]
Bug 1305993 - Break tests up to avoid timeouts

Kate, I think I already r+ed those changes, right? I don't see anything changed. I assume mozreview just flagged me again, right? Anyway, If you need a review let me know.
Attachment #8798762 - Flags: review?(ckerschb) → review+
Keywords: checkin-needed
Comment on attachment 8798762 [details]
Bug 1305993 - Break tests up to avoid timeouts

https://reviewboard.mozilla.org/r/84174/#review85444
Attachment #8798762 - Flags: review+
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/47b58740f054
Break tests up to avoid timeouts r=philor
Keywords: checkin-needed
Blocks: 1310955
Depends on: 1311239
https://hg.mozilla.org/mozilla-central/rev/47b58740f054
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Whiteboard: [domsecurity-intermittent] → [domsecurity-intermittent][checkin-needed-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/384d4c839044
Whiteboard: [domsecurity-intermittent][checkin-needed-aurora] → [domsecurity-intermittent]
Depends on: 1311599
Depends on: 1311698
You need to log in before you can comment on or make changes to this bug.