130600 - Search includes MailWindowOverlay which includes viewZoomOverlay which throws an exception.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[timeless]

yesterday morning cvs build, freebsd, littlemozilla theme.
./mozilla -mail, search>search messages

[Exception... "'[JavaScript Error: "this.bundle has no properties" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 49}]' when calling method: [nsIDOMEventListener::handleEvent]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]

What should be done?  probably at least one of these three things:
a. make search not include mailWindowOverlay
b. make mailWindowOverlay not include viewZoomOverlay
c. make viewZoomOverlay not trigger this exception :-)

Comment 1

[jag (Peter Annema)]

(a) is my suggestion, though I could see (b) as an option too.

If you don't need the text zoom code, try to avoid it (and its JS!) getting
overlaid. this goes for most of the overlays. The xul itself won't hurt too
much, because whatever can't get overlayed won't get built, but the JS will
always be there taking space.

This might mean moving the viewZoomOverlay.xul out of mailWindowOverlay and
moving it into the mail xul files (below the mailWindowOverlay include) that
actually do want this menu. Or it might mean refactoring mailWindowOverlay. I'll
leave that up to you guys.

Comment 2

[[e-mail]]

Last time I looked Search only needed the status bar XUL from mailWindowOverlay

Comment 3

[[e-mail]]

Attachment: Proposed Patch

Removes mailWindowOverlay and inlines the required elements.

Comment 4

[David :Bienvenu]

I'm a little leary of going this direction as the search window takes on more of
the attributes of a real window instead of less, but as long as you've made sure
everything still works, I can sr it.

Comment 5

[David :Bienvenu]

Comment on attachment 108737 [details] [diff] [review]
Proposed Patch

sr=bienvenu - we still include mailOverlay.js, so you won't get any savings
there...

Comment 6

[jag (Peter Annema)]

Comment on attachment 108737 [details] [diff] [review]
Proposed Patch

r=jag

Comment 7

[timeless]

checked in

Comment 8

[[e-mail]]

Oops, timeless checked this in ages ago :-)