1306007 - Remove srcset/picture feature control preference

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Edgar Chen [:edgar]]

picture and srcset features have been enabled since 38 (bug 1017875 and bug 1018389). I think they are stable enough to remove the control preference.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Part 1: Remove srcset/picture feature control preference, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 2: Drop the unused arguments of TryCreateResponsiveSelector(), v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 1: Remove srcset/picture feature control preference, v2

Comment 4

[Edgar Chen [:edgar]]

Try: https://treeherder.allizom.org/#/jobs?repo=try&revision=5592d502bb76f61a0448ab6dbbdd9f72ee5f4b6a&group_state=expanded&filter-tier=1

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 8795716 [details] [diff] [review]
Part 1: Remove srcset/picture feature control preference, v2

Review of attachment 8795716 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/security/test/mixedcontentblocker/test_main.html
@@ +163,5 @@
>  
>    function startTest() {
>      //Set the first set of mixed content settings and increment the counter.
>      //Enable <picture> and <img srcset> for the test.
> +    changePrefs([], function() {

We can remove the changePrefs entirely.

Comment 6

[Edgar Chen [:edgar]]

(In reply to Josh Matthews [:jdm] from comment #5)
> Comment on attachment 8795716 [details] [diff] [review]
> Part 1: Remove srcset/picture feature control preference, v2
> 
> Review of attachment 8795716 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/security/test/mixedcontentblocker/test_main.html
> @@ +163,5 @@
> >  
> >    function startTest() {
> >      //Set the first set of mixed content settings and increment the counter.
> >      //Enable <picture> and <img srcset> for the test.
> > +    changePrefs([], function() {
> 
> We can remove the changePrefs entirely.

changePrefs also adds some base preference [1], like "security.mixed_content.block_display_content", we can not remove it entirely.
[1] https://dxr.mozilla.org/mozilla-central/source/dom/security/test/mixedcontentblocker/test_main.html#23

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8795716 [details] [diff] [review]
Part 1: Remove srcset/picture feature control preference, v2

Review of attachment 8795716 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/security/test/mixedcontentblocker/test_main.html
@@ +162,5 @@
>    }
>  
>    function startTest() {
>      //Set the first set of mixed content settings and increment the counter.
>      //Enable <picture> and <img srcset> for the test.

Ah, this comment could be removed.

Comment 8

[Edgar Chen [:edgar]]

Attachment: Part 1: Remove srcset/picture feature control preference, v3, r=jdm

Carrying forward r+ and addressing comment #7.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Part 1 doesn't apply cleanly. Please rebase.

Comment 10

[Edgar Chen [:edgar]]

Attachment: Part 1: Remove srcset/picture feature control preference, v4, r=jdm

Rebase

Comment 11

[Edgar Chen [:edgar]]

Comment on attachment 8796846 [details] [diff] [review]
Part 1: Remove srcset/picture feature control preference, v4, r=jdm

Review of attachment 8796846 [details] [diff] [review]:
-----------------------------------------------------------------

This patch touches WebIDL files, so it requires review from DOM peer.
Could you help to review webidl changes, Olli?
Thank you.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82d198b87307
Part 1: Remove srcset/picture feature control preference; r=jdm,smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f435a5a9ad0
Part 2: Drop the unused arguments of TryCreateResponsiveSelector(); r=jdm

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/82d198b87307
https://hg.mozilla.org/mozilla-central/rev/4f435a5a9ad0