Closed
Bug 1306007
Opened 4 years ago
Closed 4 years ago
Remove srcset/picture feature control preference
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
Details
Attachments
(2 files, 3 obsolete files)
3.61 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
43.24 KB,
patch
|
edgar
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
picture and srcset features have been enabled since 38 (bug 1017875 and bug 1018389). I think they are stable enough to remove the control preference.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Attachment #8795712 -
Attachment is obsolete: true
Assignee | ||
Comment 4•4 years ago
|
||
Try: https://treeherder.allizom.org/#/jobs?repo=try&revision=5592d502bb76f61a0448ab6dbbdd9f72ee5f4b6a&group_state=expanded&filter-tier=1
Assignee | ||
Updated•4 years ago
|
Attachment #8795713 -
Flags: review?(josh)
Assignee | ||
Updated•4 years ago
|
Attachment #8795716 -
Flags: review?(josh)
Updated•4 years ago
|
Attachment #8795713 -
Flags: review?(josh) → review+
Comment 5•4 years ago
|
||
Comment on attachment 8795716 [details] [diff] [review] Part 1: Remove srcset/picture feature control preference, v2 Review of attachment 8795716 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/security/test/mixedcontentblocker/test_main.html @@ +163,5 @@ > > function startTest() { > //Set the first set of mixed content settings and increment the counter. > //Enable <picture> and <img srcset> for the test. > + changePrefs([], function() { We can remove the changePrefs entirely.
Attachment #8795716 -
Flags: review?(josh) → review+
Assignee | ||
Comment 6•4 years ago
|
||
(In reply to Josh Matthews [:jdm] from comment #5) > Comment on attachment 8795716 [details] [diff] [review] > Part 1: Remove srcset/picture feature control preference, v2 > > Review of attachment 8795716 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/security/test/mixedcontentblocker/test_main.html > @@ +163,5 @@ > > > > function startTest() { > > //Set the first set of mixed content settings and increment the counter. > > //Enable <picture> and <img srcset> for the test. > > + changePrefs([], function() { > > We can remove the changePrefs entirely. changePrefs also adds some base preference [1], like "security.mixed_content.block_display_content", we can not remove it entirely. [1] https://dxr.mozilla.org/mozilla-central/source/dom/security/test/mixedcontentblocker/test_main.html#23
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 8795716 [details] [diff] [review] Part 1: Remove srcset/picture feature control preference, v2 Review of attachment 8795716 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/security/test/mixedcontentblocker/test_main.html @@ +162,5 @@ > } > > function startTest() { > //Set the first set of mixed content settings and increment the counter. > //Enable <picture> and <img srcset> for the test. Ah, this comment could be removed.
Assignee | ||
Comment 8•4 years ago
|
||
Carrying forward r+ and addressing comment #7.
Attachment #8795716 -
Attachment is obsolete: true
Attachment #8796413 -
Flags: review+
Assignee | ||
Updated•4 years ago
|
Keywords: checkin-needed
Comment 9•4 years ago
|
||
Part 1 doesn't apply cleanly. Please rebase.
Flags: needinfo?(echen)
Keywords: checkin-needed
Assignee | ||
Comment 10•4 years ago
|
||
Rebase
Attachment #8796413 -
Attachment is obsolete: true
Flags: needinfo?(echen)
Attachment #8796846 -
Flags: review+
Assignee | ||
Comment 11•4 years ago
|
||
Comment on attachment 8796846 [details] [diff] [review] Part 1: Remove srcset/picture feature control preference, v4, r=jdm Review of attachment 8796846 [details] [diff] [review]: ----------------------------------------------------------------- This patch touches WebIDL files, so it requires review from DOM peer. Could you help to review webidl changes, Olli? Thank you.
Attachment #8796846 -
Flags: review?(bugs)
Updated•4 years ago
|
Attachment #8796846 -
Flags: review?(bugs) → review+
Comment 12•4 years ago
|
||
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/82d198b87307 Part 1: Remove srcset/picture feature control preference; r=jdm,smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/4f435a5a9ad0 Part 2: Drop the unused arguments of TryCreateResponsiveSelector(); r=jdm
Comment 13•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/82d198b87307 https://hg.mozilla.org/mozilla-central/rev/4f435a5a9ad0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•