Closed Bug 1306014 Opened 5 years ago Closed 5 years ago

"ipc/mscom/MainThreadInvoker.cpp(118): error C2039: 'SetAPCPending': is not a member of 'mozilla::widget::WinUtils'" with --disable-accessibility

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(2 files)

Fallout from bug 1304883. SetAPCPending() is defined within an ifdef ACCESSIBILITY block but gets used unconditionally in MainThreadInvoker.cpp.
This fixes it for me locally. Not sure if it's the right fix, though :)
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8795727 - Flags: review?(aklotz)
Comment on attachment 8795727 [details] [diff] [review]
add an ACCESSIBILITY ifdef around the SetAPCPending() call in MainThreadInvoker.cpp

Review of attachment 8795727 [details] [diff] [review]:
-----------------------------------------------------------------

That'll work.
Attachment #8795727 - Flags: review?(aklotz) → review+
Comment on attachment 8795727 [details] [diff] [review]
add an ACCESSIBILITY ifdef around the SetAPCPending() call in MainThreadInvoker.cpp

Actually, it'll fix the build but it will break the rest of that code ;-)

I think that the best way to take care of this is to modify the moz.build to exclude certain things. I'll take it.
Attachment #8795727 - Flags: review+ → review-
Thanks, that's exactly what I was worried about.
Comment on attachment 8795837 [details]
Bug 1306014: Modify ipc/mscom/moz.build to only build essentials when a11y is disabled in build config;

https://reviewboard.mozilla.org/r/81798/#review80416
Attachment #8795837 - Flags: review?(jmathies) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a310a3cdfdc6
Modify ipc/mscom/moz.build to only build essentials when a11y is disabled in build config; r=jimm
https://hg.mozilla.org/mozilla-central/rev/a310a3cdfdc6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.