1306014 - "ipc/mscom/MainThreadInvoker.cpp(118): error C2039: 'SetAPCPending': is not a member of 'mozilla::widget::WinUtils'" with --disable-accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Fallout from bug 1304883. SetAPCPending() is defined within an ifdef ACCESSIBILITY block but gets used unconditionally in MainThreadInvoker.cpp.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: add an ACCESSIBILITY ifdef around the SetAPCPending() call in MainThreadInvoker.cpp

This fixes it for me locally. Not sure if it's the right fix, though :)

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8795727 [details] [diff] [review]
add an ACCESSIBILITY ifdef around the SetAPCPending() call in MainThreadInvoker.cpp

Review of attachment 8795727 [details] [diff] [review]:
-----------------------------------------------------------------

That'll work.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8795727 [details] [diff] [review]
add an ACCESSIBILITY ifdef around the SetAPCPending() call in MainThreadInvoker.cpp

Actually, it'll fix the build but it will break the rest of that code ;-)

I think that the best way to take care of this is to modify the moz.build to exclude certain things. I'll take it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Thanks, that's exactly what I was worried about.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1306014: Modify ipc/mscom/moz.build to only build essentials when a11y is disabled in build config;

Review commit: https://reviewboard.mozilla.org/r/81798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81798/

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8795837 [details]
Bug 1306014: Modify ipc/mscom/moz.build to only build essentials when a11y is disabled in build config;

https://reviewboard.mozilla.org/r/81798/#review80416

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a310a3cdfdc6
Modify ipc/mscom/moz.build to only build essentials when a11y is disabled in build config; r=jimm

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a310a3cdfdc6