1306062 - browser.js shouldn't send "fromCache":true flag when device is offline for tabs that couldn't load correctly (server not found, etc)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P3)

Description

[:Grisha Kruglov]

This is a follow up for Bug 1304914, which ensures we won't display "offline version" notifications on error pages while device is offline. Ideally, we want to fix the root of the problem, which is that currently if tab loaded in an error state while device is offline, we attach "fromCache":true flag with the PageShow and StateChange messages that are sent to javaland.

Currently the "error state" covers both types of events:
1) 404 on the server (couldn't locate a page on a site)
2) "server not found" type events

We want to display "offline version" notifications for the first type (content is available), but not for the second (no content!).

Current solution doesn't display the notification on either one of those, which is better than displaying it on both, but far from ideal.

Comment 1

[:Grisha Kruglov]

Flagging this for triage. Offline browsing is now enabled for the whole population, so it would be good to fix up these edge cases.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage]
P3 as a backlog feature enhancement.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.