[mozlint] Create a "compact" formatter similar to the one in eslint

RESOLVED FIXED in Firefox 57

Status

Testing
Lint
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This doesn't need to be identical to the eslint one (I think even eslint's is too verbose), but that can be used as a guideline. Example format can be found here:
http://eslint.org/docs/user-guide/formatters/#compact

Maybe something like:
<path> <line>:<col> <message> - <rule> (<linter>)

The goal would be each rule takes up a single line, and use as little space as possible. It would also be nice to colorize as long as a terminal is detected, a similar approach as the 'stylish' formatter could be used. It might be worthwhile even sharing some of the colorization code between the two.

Code for mozlint formatters lives here:
https://dxr.mozilla.org/mozilla-central/source/python/mozlint/mozlint/formatters
(Assignee)

Updated

11 months ago
Mentor: ahalberstadt@mozilla.com
(Assignee)

Comment 1

11 months ago
Thanks for volunteering to look at this Deepa! Please don't hesitate to ask questions if you need some guidance.
Assignee: nobody → deepsrijit1105
Status: NEW → ASSIGNED

Comment 2

11 months ago
Hi Andrew,

I would not get much time to work on this till Sunday. I will submit a patch on Monday. Please don't remove me from assignee :-) 

Thanks.
(Assignee)

Comment 3

11 months ago
Thanks for the heads up Deepa, no problem at all!
(Assignee)

Comment 4

8 months ago
Hi Deepa, was this something you were still interested in?
Flags: needinfo?(deepsrijit1105)
(Assignee)

Updated

8 months ago
Assignee: deepsrijit1105 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(deepsrijit1105)
(Assignee)

Updated

6 months ago
Assignee: nobody → ahalberstadt
Mentor: ahalberstadt@mozilla.com
Status: NEW → ASSIGNED
(Assignee)

Updated

6 months ago
Blocks: 1387555
Comment hidden (mozreview-request)

Comment 6

6 months ago
mozreview-review
Comment on attachment 8893926 [details]
Bug 1306122 - [mozlint] Create a compact formatter that mimics the eslint 'compact' format,

https://reviewboard.mozilla.org/r/164990/#review171198

lgtm
Attachment #8893926 - Flags: review?(armenzg) → review+

Comment 7

6 months ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adf616622c4a
[mozlint] Create a compact formatter that mimics the eslint 'compact' format, r=armenzg

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/adf616622c4a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.