1306122 - [mozlint] Create a "compact" formatter similar to the one in eslint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Andrew Halberstadt [:ahal]]

This doesn't need to be identical to the eslint one (I think even eslint's is too verbose), but that can be used as a guideline. Example format can be found here:
http://eslint.org/docs/user-guide/formatters/#compact

Maybe something like:
<path> <line>:<col> <message> - <rule> (<linter>)

The goal would be each rule takes up a single line, and use as little space as possible. It would also be nice to colorize as long as a terminal is detected, a similar approach as the 'stylish' formatter could be used. It might be worthwhile even sharing some of the colorization code between the two.

Code for mozlint formatters lives here:
https://dxr.mozilla.org/mozilla-central/source/python/mozlint/mozlint/formatters

Comment 1

[Andrew Halberstadt [:ahal]]

Thanks for volunteering to look at this Deepa! Please don't hesitate to ask questions if you need some guidance.

Comment 2

[Deepa]

Hi Andrew,

I would not get much time to work on this till Sunday. I will submit a patch on Monday. Please don't remove me from assignee :-) 

Thanks.

Comment 3

[Andrew Halberstadt [:ahal]]

Thanks for the heads up Deepa, no problem at all!

Comment 4

[Andrew Halberstadt [:ahal]]

Hi Deepa, was this something you were still interested in?

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1306122 - [mozlint] Create a compact formatter that mimics the eslint 'compact' format,

Review commit: https://reviewboard.mozilla.org/r/164990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164990/

Comment 6

[Armen [:armenzg]]

Comment on attachment 8893926 [details]
Bug 1306122 - [mozlint] Create a compact formatter that mimics the eslint 'compact' format,

https://reviewboard.mozilla.org/r/164990/#review171198

lgtm

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adf616622c4a
[mozlint] Create a compact formatter that mimics the eslint 'compact' format, r=armenzg

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/adf616622c4a