1306132 - Make thPlatformMap use _.indexOf() to determine order rather than arbitrary numbers.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Cam brought this up in a recent review, and I think this would be better in the long run for the platform mapping.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1306132 > mozilla:master

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8795938 [details] [review]
[treeherder] KWierso:1306132 > mozilla:master

This is the PR-in-progess I mentioned on IRC. The order appears to be correct, and as long as none of our platform names end up being just a number, I don't see any reason for that to never be true. 

Not tied to this at all and wouldn't be offended if you wontfix it, though... :)

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1306132v2 > mozilla:master

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8796306 [details] [review]
[treeherder] KWierso:1306132v2 > mozilla:master

Oops, wrong bug.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1306132v2 > mozilla:master

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8796307 [details] [review]
[treeherder] KWierso:1306132v2 > mozilla:master

Stop that, autolander!

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8795938 [details] [review]
[treeherder] KWierso:1306132 > mozilla:master

Looks good.  Made one suggestion.  :)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8795938 [details] [review]
[treeherder] KWierso:1306132 > mozilla:master

I've rebased this onto master and made it so the map is only generated once per page load. I wasn't sure how to generate the map in values.js directly, since it'd be referencing one of the other values, and I don't know how to do that.

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8795938 [details] [review]
[treeherder] KWierso:1306132 > mozilla:master

Looks good!

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f29c1fb610712bb32d5da0920168d141c771a916
Bug 1306132 - Remove the need to manually add a platform's priority (#1879) r=camd