Closed
Bug 130614
Opened 22 years ago
Closed 22 years ago
Trunk M1RC2 crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder]
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: greer, Assigned: bugs)
References
Details
(Keywords: crash, topcrash+)
Crash Data
Attachments
(1 file)
1.19 KB,
patch
|
bryner
:
review+
timeless
:
superreview+
jesup
:
approval+
|
Details | Diff | Splinter Review |
Judging from a quick look at the stacks and comments, some installations of M099 (and the Trunk) are having trouble converting existing bookmarks. Build ID range: 24 2002031106 (Windows M099) 2 2002031109 (Trunk) 1 2002030511 (Trunk) Stack Trace: nsBookmarksService::ParseFavoritesFolder [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 3174] nsBookmarksService::ImportSystemBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 3271] nsBookmarksService::HandleSystemBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 3286] nsBookmarksService::HasAssertion [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 3874] CompositeDataSourceImpl::HasAssertion [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp line 1146] CompositeDataSourceImpl::OnAssert [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp line 1548] nsBookmarksService::OnAssert [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 5424] InMemoryDataSource::Assert [d:\builds\seamonkey\mozilla\rdf\base\src\nsInMemoryDataSource.cpp line 1389] nsBookmarksService::LoadBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 4953] nsBookmarksService::ReadBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cp p line 4682] XPTC_InvokeByIndex [d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp line 106] XPCWrappedNative::CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp line 2027] XPC_WN_CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp line 1267] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 790] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 2746] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 806] js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 881] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c line 3390] nsJSContext::CallEventHandler [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp line 1019] GlobalWindowImpl::RunTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp line 4125] GlobalWindowImpl::TimerCallback [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp line 4437] nsTimerImpl::Process [d:\builds\seamonkey\mozilla\xpcom\threads\nsTimerImpl.cpp line 330] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 591] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 524] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 1072] USER32.dll + 0x3c076 (0x77d7c076) USER32.dll + 0x3c076 (0x77d7c076) _except_handler3() kernel32.dll + 0x3bb86 (0x77e9bb86) Source File : http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/components/bookmarks/sr c/nsBookmarksService.cpp line : 3174 (3951171) Comments: 0.9.9 (release) crashed on start..can't actually start it at all! (3931885) Comments: Installation of talkback enabled Full Installer (Win32) 0.9.9Installer asking: Mozilla is currentl not your default browser. Do you want ... => YesInstallation aborted in a crash: Dr. Watson => exception: acces violation (0xc0000005) address (3931885) Comments: 0x60078146 (3931400) Comments: Starting Mozilla up for the first time; just after profiles were converted. (3929086) URL: http://tv.netscape.com (3929086) Comments: Crash on first startup of 0.9.9 installed over 0.9.8
Comment 1•22 years ago
|
||
This is showing up on the Trunk in decent numbers again: nsBookmarksService::ParseFavoritesFolder 16 130614 NEW ben@netscape.com --- 2002-03-14 BBID range: 4165360 - 4540098 Min/Max Seconds since last crash: 1 - 188 Min/Max Runtime: 3 - 189 Crash data range: 2002-03-18 to 2002-03-27 Build ID range: 2002031711 to 2002032711 Keyword List : start(5), Stack Trace: nsBookmarksService::ParseFavoritesFolder [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 3195] nsBookmarksService::ImportSystemBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 3294] nsBookmarksService::HandleSystemBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 3309] nsBookmarksService::HasAssertion [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 3897] CompositeDataSourceImpl::HasAssertion [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp line 1146] CompositeDataSourceImpl::OnAssert [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp line 1548] nsBookmarksService::OnAssert [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 5434] InMemoryDataSource::Assert [d:\builds\seamonkey\mozilla\rdf\base\src\nsInMemoryDataSource.cpp line 1389] nsBookmarksService::LoadBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 4873] nsBookmarksService::ReadBookmarks [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\nsBookmarksService.cpp line 4705] XPTC_InvokeByIndex [d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp line 106] XPCWrappedNative::CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp line 2027] XPC_WN_CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp line 1267] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 790] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 2746] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 806] js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c line 881] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c line 3414] nsJSContext::CallEventHandler [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp line 1019] GlobalWindowImpl::RunTimeout [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp line 4225] GlobalWindowImpl::TimerCallback [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp line 4572] nsTimerImpl::Process [d:\builds\seamonkey\mozilla\xpcom\threads\nsTimerImpl.cpp line 330] handleMyEvent [d:\builds\seamonkey\mozilla\xpcom\threads\nsTimerImpl.cpp line 381] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 597] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 530] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 1078] KERNEL32.DLL + 0x228e0 (0xbff928e0) 0x00648c18 Source File : http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp line : 3195 (4540098) Comments: Win 95. ran mozilla.exe -profilemanagerclicked "Start Mozilla" (4539941) Comments: Win 95 ran: mozilla.exe -mailthen attempted to open a browser window (4539882) Comments: crash on startup win 95see bug 130234 (4537854) Comments: please tell me that 1.0 isnt going to ship with a Win 95 blocker.... (4480378) Comments: I keep getting a error where it says that the file APPCOMPS.DLL in C:\Programmer\mozilla.org\Mozilla\components has generated a error.This error has made it impossible for me to start the mozilla browser up. :"( (4425786) Comments: This has been happening alot.... I've been installing alot of these builds but none of them will start up I get this error all the time and I'm hoping it will be solved in the next couple of builds.Goodluckand May The Force Be With You.:-) (4333724) Comments: Bug 130234 (4306803) Comments: see bug 130234 (4227061) Comments: crash on startup Taking a look at bug 130234 from the comments, it looks like this might be a Windows 95 specific issue.
Summary: Trunk M099 crashes on startup converting bookmarks [@ nsBookmarksService::ParseFavoritesFolder] → Trunk M099 crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder]
This is the same as http://bugzilla.mozilla.org/show_bug.cgi?id=130234. One user in the bug report is able to reproduce the crash.
Comment 3•22 years ago
|
||
nsbeta1+/adt2 per Nav triage team, ->1.0
Comment 4•22 years ago
|
||
Bug 130234 has been verified fixed for a general case...so this bug should remain open until this particular Win95 crash at nsBookmarksService::ParseFavoritesFolder is fixed. Making topcrash+.
Comment 5•22 years ago
|
||
Seems to be working fine on build 4-12-2002, using win 95
Comment 6•22 years ago
|
||
Still crashing on startup with build 2002041503 on Windows 95 (retail version, whose hard-drive has never been tainted by the presence of any version of IE) Today I notice that it gets just *slightly* farther before it crashes. Previously, it would paint the title-bar and border of the browser window, but the client area would still be blank when it crashes. Today it paints the chrome too, but the brwoser-content area is still blank when it crashes. Talkback TB5224442K
Comment 7•22 years ago
|
||
I think this is the problem: 3311 nsCOMPtr<nsIFile> favoritesDirectory; 3312 fileLocator->Get("Favs", NS_GET_IID(nsIFile), getter_AddRefs(favoritesDirectory)); 3313 3314 return ParseFavoritesFolder(favoritesDirectory, aParentFolder); it should check favoritesDirectory before call ParseFavoritesFolder
Comment 8•22 years ago
|
||
continue with my previous comment. It crash at 3220 nsBookmarksService::ParseFavoritesFolder(nsIFile* aDirectory, nsIRDFResource* aParentResource) 3221 { 3222 nsresult rv; 3223 3224 nsCOMPtr<nsISimpleEnumerator> entries; 3225 rv = aDirectory->GetDirectoryEntries(getter_AddRefs(entries)); because aDirectory is null You could also fix this crash by adding NS_ENSURE_ARG_POINTER(aDirectory); NS_ENSURE_ARG_POINTER(aParentResource); in the beginning of ParseFavoritesFolder
this makes perfect sense, w95osr0 didn't define the favorites folder, that was something that some ie defined (definitely by ie4 - aka w98, perhaps ie3?). So when we get the favorites directory, we assume it exists. We could probably crash on NT4sp3 or earlier too.
Comment 10•22 years ago
|
||
What are the chances we could get a fix for this one before Friday, 04.26?
Whiteboard: [adt2] → [adt2] [ETA needed]
Updated•22 years ago
|
Keywords: mozilla1.0+
Assignee | ||
Comment 11•22 years ago
|
||
chances are good.
Status: NEW → ASSIGNED
Whiteboard: [adt2] [ETA needed] → [adt2] [ETA: 04/20/02]
Reporter | ||
Comment 12•22 years ago
|
||
Changing the summary M099 -> M100. And FWIW, this crash is not limited to Win95 as the summary suggests (see timeless' comment #9): M100 (nsBookmarksService::ParseFavoritesFolder): 10 8 (2002041514) Windows NT 5.1 build 2600 (Win XP) 1 (2002041717) Windows NT 5.1 build 2600 (Win XP) 1 (2002041717) Windows 98 4.10 build 67766446 Trunk (nsBookmarksService::ParseFavoritesFolder): 5 2 (2002041113) Windows 98 4.90 build 73010104 1 (2002041506) Windows 95 4.0 build 67109814 1 (2002040910) Windows NT 5.1 build 2600 (Win XP) 1 (2002040809) Windows 95 4.0 build 67109814
Summary: Trunk M099 crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder] → Trunk M100 crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder]
Assignee | ||
Comment 13•22 years ago
|
||
Check to see if favoritesFolder exists before calling ParseFavoritesFolder. I prefer to put the check before calling ParseFavoritesFolder rather than inside it, as my comment can live near-by the directory-service stuff, and ParseFavoritesFolder can be called recursively, and this check is only needed once.
Comment 14•22 years ago
|
||
Comment on attachment 80165 [details] [diff] [review] patch r=bryner
Attachment #80165 -
Flags: review+
Assignee | ||
Comment 15•22 years ago
|
||
sr=hyatt via IRC. Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 16•22 years ago
|
||
Yes! Confirming fixedness on Windows 95 build 2002042209 It has been sooo long since I have been able to run Mozilla on my Win 95 box. Many thanks!
Comment 17•22 years ago
|
||
*** Bug 140040 has been marked as a duplicate of this bug. ***
Comment 18•22 years ago
|
||
Verified fixed. No crashes on the MozillaTrunk or Mozilla1.0 branch after 4/20 checkin. This did get checked in to both the Trunk and Branch right?
Status: RESOLVED → VERIFIED
Comment 19•22 years ago
|
||
*** Bug 140201 has been marked as a duplicate of this bug. ***
Comment 20•22 years ago
|
||
This bug may yet live: see bug 140201, which was on RC1...
Comment 21•22 years ago
|
||
I have installed a clean, IE-less 98lite environment alongside Windows 2000. RC1 (build ID 2002041711) crashes on startup on 98lite, and therefore on Windows 95 w/o IE as well. Same stack trace as seen on bug 140201. It works fine, very well in fact, on Win2000. Forgive my use of the loudspeaker, but: THIS BUG IS NOT FIXED or it is not patched on the 1.0 branch! I won't spam this nor any duplicate bug of this anymore. I'm not a n00b; I know better. But to the powers of Mozilla that be, if 1.0 doesn't work on Windows 95, don't blame me, 'cause I warned you. :)
Reporter | ||
Comment 22•22 years ago
|
||
David R. - The M1.0 Release candidate was cut on 4/17. The checkin for the bug was 4/20 (comment #15). That means we don't expect to see the fix in the Release Candidate. Download a Nightly build and let us know if you can still crash it. We have no crashes on the Trunk after 4/20 for this bug. Thanks for the hard work.
Comment 23•22 years ago
|
||
I'm still having this crash on the 1.0 branch 5/01 build {2002050108}. Talkback incident TB5824217K. However... it IS fixed on the trunk! (Same date and build as the branch.) Finally, Moz works again on 98lite... Sorry for the misunderstanding: I was under the impression that this fix was checked into the trunk AND the 1.0 branch. I hope I haven't caused too much trouble by not watching dates and builds more carefully. It'd be nice to have this patch in the 1.0 nightlies even before RC2, time and priorities permitting, though, since the change to the code is small.
Comment 24•22 years ago
|
||
*** Bug 142854 has been marked as a duplicate of this bug. ***
Comment 25•22 years ago
|
||
reopening, the reporter in bug 142854 got the crash with build 0507 (branch) with win95
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 26•22 years ago
|
||
If it helps for me to post any information about my system (or favorites folder) then let me know.
Comment 27•22 years ago
|
||
This fix appears to have never been checked into the branch (I don't see any comments about this patch making it onto the branch), which would explain why people are still seeing this with Mozilla 1.0 Branch builds. Ben: Can you verify that this was only checked into the Trunk? Can we get ADT approval to get this onto the Mozilla1.0 Branch as well?
Summary: Trunk M100 crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder] → Trunk M1BR crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder]
Comment 28•22 years ago
|
||
Has the bug in 142854 been fixed in the 1.0RC2 build ?
Reporter | ||
Comment 29•22 years ago
|
||
Brian B., The first day's data shows a crash already at this signature, which could lead me to believe that this has not been checked in on the branch prior to M1RC2. M1RC2 (nsBookmarksService::ParseFavoritesFolder): 1 (6168726) - [Windows NT 5.1 build 2600] (Build 2002051008): opening viruslist of McAfee virusscanner 4.5.1 dutch edition Can you still reproduce this with M1RC2?
Comment 30•22 years ago
|
||
I haven't tried RC2 yet. I was hoping to find out if it had been fixed before going through the process of another lengthy download. I have already downloaded two builds - RC1 and the nightly build from ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-05-07-08-1.0.0/ .
Comment 31•22 years ago
|
||
I can test RC2 on Win95 on monday. I am pretty sure this was only fixed on the trunk.
Comment 32•22 years ago
|
||
Eh. Bad. I just tried RC2 on my IE-less Windows 95 box. It ran okay with my old profile, but when I created a fresh profile, same old crash in APCOMPS.DLL I will post a talkback ID if it can ever get through to the server and get my crash data submitted... So it looks like this has NOT been checked into the branch, and that it very badly needs to be!
Comment 33•22 years ago
|
||
Cheers for testing that for me. It's saved me from doing a download.
Comment 34•22 years ago
|
||
To confirm - my system is also Windows 95 and IE-less.
Comment 35•22 years ago
|
||
Updating summary wiht M1RC2 since this is a topcrasher for Mozilla 1.0 RC2. We have already verified this fix on the trunk, so it should be safe to check this on to the Mozilla 1.0 branch as well. What do we need to do to get approval for branch checkin?
Summary: Trunk M1BR crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder] → Trunk M1RC2 crashes on startup with Win95 [@ nsBookmarksService::ParseFavoritesFolder]
Comment 36•22 years ago
|
||
That talkback was TB6244473H
Comment 37•22 years ago
|
||
Comment on attachment 80165 [details] [diff] [review] patch comment 15: sr=hyatt
Attachment #80165 -
Flags: superreview+
Comment 38•22 years ago
|
||
topcrash ->adt1. adt1.0.0 Why was this reopened if it is fixed on the trunk? Ben, please get drivers approval.
Keywords: adt1.0.0
Whiteboard: [adt2] [ETA: 04/20/02] → [adt1]
Comment 39•22 years ago
|
||
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending Driver's approval. After, checking in, please add the fixed1.0 keyword.
Blocks: 143200
Comment 40•22 years ago
|
||
fixed
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Comment 41•22 years ago
|
||
Comment on attachment 80165 [details] [diff] [review] patch a=rjesup@wgate.com
Attachment #80165 -
Flags: approval+
Updated•22 years ago
|
Whiteboard: [adt1] [Needs a=] → [adt1 RTM] [Needs a=]
Comment 42•22 years ago
|
||
Is this supposed to be fixed ? I just downloaded a build using http://ftp.mozilla.org/pub/mozilla/nightly/2002-05-17-08-1.0.0/mozilla-win32- installer.exe and this produces the same error in appcomps.dll. I don't know if I downloaded the right file because the numbering of nightly builds isn't explained on the website. The talkback id is TB6410631K.
Assignee | ||
Comment 43•22 years ago
|
||
This is not fixed1.0.0, I'll be checking this in on the branch as soon as my branch build completes in about 30 min.
Comment 45•22 years ago
|
||
tested with branch build 2002052006 on Windows 95. No crash, neither with existing profile nor new profile
Reporter | ||
Comment 46•22 years ago
|
||
The last incidents in talkback were on the branch in the 5-18 build prior to checkin. Verified fixed on branch and Trunk.
Status: RESOLVED → VERIFIED
Whiteboard: [adt1 RTM] [Needs a=],custrtm-
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•13 years ago
|
Crash Signature: [@ nsBookmarksService::ParseFavoritesFolder]
You need to log in
before you can comment on or make changes to this bug.
Description
•