Update rust parser for fragmented file

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ayang, Assigned: ayang)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

No description provided.
Assignee: nobody → ayang
Blocks: 1304254
Comment on attachment 8795955 [details]
Bug 1306164 - Update rust parser for fragmented file.

https://reviewboard.mozilla.org/r/81932/#review80844

::: media/libstagefright/binding/mp4parse/Cargo.toml:21
(Diff revision 1)
>  exclude = [
>    "*.mp4",
>  ]
>  
>  [dependencies]
> -byteorder = "0.5.0"
> +byteorder = { version = "0.5.0" }

You didn't update mp4parse-cargo.patch so this will get clobbered in the next update. That's been bit-rotted anyway; I'll prepare a followup patch.
Comment on attachment 8795955 [details]
Bug 1306164 - Update rust parser for fragmented file.

https://reviewboard.mozilla.org/r/81932/#review80846

Technically we're breaking symver here, but as long as the gecko refers to the in-tree source that shouldn't matter; it's the same as having the upstream source for the crate be in-tree.
Attachment #8795955 - Flags: review?(giles) → review+
Comment on attachment 8796341 [details]
Bug 1306164 - Drop byteorder from mp4parse update script.

https://reviewboard.mozilla.org/r/82228/#review80870
Attachment #8796341 - Flags: review?(kinetik) → review+
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ea6813874d8
Update rust parser for fragmented file. r=rillian
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f9134490dd7
Drop byteorder from mp4parse update script. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/4ea6813874d8
https://hg.mozilla.org/mozilla-central/rev/2f9134490dd7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.