Rename form validation anchor to a more generic name for better reuse

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: scottwu, Assigned: scottwu)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
FormValidationAnchor is a property in tabbrowser.xml that is used to open up a popup panel. It was created for form validation but it could be reused in other scenarios. I would like to rename it to make it more generic.

http://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.xml#142
Comment hidden (mozreview-request)
(Assignee)

Comment 2

10 months ago
Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c18893026b0e
Blocks: 1283384
Comment on attachment 8796412 [details]
Bug 1306251 - Rename form validation anchor to make it more generic

https://reviewboard.mozilla.org/r/82280/#review81772

Thanks!
Attachment #8796412 - Flags: review?(mconley) → review+
(Assignee)

Comment 4

10 months ago
Thanks Mike!
Keywords: checkin-needed

Comment 5

10 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4b2ff6e79ac
Rename form validation anchor to make it more generic r=mconley
Keywords: checkin-needed

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f4b2ff6e79ac
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.