1306270 - [One-off searches] Change of default search engine takes effect only after closing/reopening the Awesomebar

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect, P3)

Description

[Liviu Cirdei]

[Affected versions]:
Nightly 52.0a1 Build ID 20160928030201

[Affected platforms]:
All (Windows 10, Mac 10.12, Ubuntu 16.04)
 
[Steps to reproduce]:
1. Open Firefox with a new profile.
2. Type something in the Awesomebar (e.g "moz") - > First result is "moz - Search with Google" OK
3. Right click on one one-off searches engine and set it as the default search engine (e.g. "Yahoo"). 
4. Mouse over the first result in the Awesomebar.
5. Click the hovered result to perform a search

[Expected result]:
 4. Results from Awesomebar should reflect the fact that the search will be made with the new default engine (e.g. First result should be "moz - Search with Yahoo").
 5. Search is performed using the new default search engine (Yahoo).
 
 
[Actual result]
4. Results from Awesomebar show that the search will be made using the old default engine (Google).
5. Search is performed using the old default search engine (Google).

[Notes]
1. After closing and reopening the Awesomebar the default search engine changes take place (Yahoo is the default).
2. In Search bar changing the default search engine works fine (no need to close/reopen the search bar) EXCEPT the first time you change the default search engine after you followed the steps from this bug.

Comment 1

[laszlo.bialis]

The issue is reproducible with the above steps on Quantumbar also.

Comment 2

[Dão Gottwald [:dao]]

It seems unlikely that we will fix this as part of the current quantumbar project.

Comment 3

[Mark Banner (:standard8)]

Moving to address bar, as I suspect address bar code will be needed here - to pick up the change of default and do the appropriate re-search.

Comment 4

[Drew Willcoxon :adw]

Harry, it looks like the new one-offs show your default engine (whereas the old ones didn't). Is that right/expected?

Comment 5

[Harry Twyford]

This is how it appears in the megabar spec, so I'm going to pass this to Verdi to see if this was intentional.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Harry, if this is still a concern we should directly ping Verdi on Slack, off-hand though it seems to be per-spec.
The bug is still valid anyway.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The contextual menu has been removed, thus this can't happen anymore, we'll fix it if it should be back.