1306316 - failure in test-wip.t

Status: RESOLVED FIXED

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[Māris Fogels [:mars] (please needinfo)]

hgext/configwizard/tests/test-wip.t is failing on the CI server.  The error appears to be an over-specified path.  The test appears to assume that the hgext/ directory's parent is named 'version-control-tools', which is not the case in CI or in Vagrant.

--- test-wip.t	2016-09-29 13:05:34.331070336 +0000
+++ test-wip.t.err	2016-09-29 13:05:34.331070336 +0000
@@ -220,7 +220,7 @@
    wip = '{label("log.branch", branches)} {label("changeset.{phase}", rev)}{label("changeset.{phase}", ":")}{label("changeset.{phase}", short(node))} {label("grep.user", author|user)}{label("log.tag", if(tags," {tags}"))}{label("log.tag", if(fxheads," {fxheads}"))} {label("log.bookmark", if(bookmarks," {bookmarks}"))}\n{label(ifcontains(rev, revset("."), "desc.here"),desc|firstline)}'
    [extensions]
    pager =
-  +firefoxtree = */version-control-tools/hgext/firefoxtree (glob)
+  +firefoxtree = /var/lib/jenkins/jobs/mozreviewci-nd/workspace/hgext/firefoxtree
    [pager]
    pager = LESS=FRSXQ less
    attend-help = true

Comment 1

[Māris Fogels [:mars] (please needinfo)]

Attachment: tests: fix failure in test-wip.t (bug 1306316)

Fixed a path test in test-wip.t that includes the project checkout
directory name.  The checkout directory name varies between
environments (and developers), so restrict the test to in-project
paths.

Review commit: https://reviewboard.mozilla.org/r/82132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82132/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8796224 [details]
tests: fix failure in test-wip.t (bug 1306316)

https://reviewboard.mozilla.org/r/82132/#review80710

Fixups to fixups.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/49af0a81e446
tests: fix failure in test-wip.t r=gps