1306319 - Fix layer violations

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Franziskus Kiefer [:franziskus]]

Looks like I introduced layer violations with bug 957105 after all.

Comment 1

[Franziskus Kiefer [:franziskus]]

Attachment: fix-boundaries.patch

This should fix the modular builds, i.e. moved the valutes from certt.h I need to ecl-curve.h and split the ectests into freebl ectests and pk11 ectests.

Comment 2

[Daiki Ueno [:ueno]]

Comment on attachment 8796537 [details] [diff] [review]
fix-boundaries.patch

Review of attachment 8796537 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for working on that.  It looks good and the build succeeded here.  One thing however is that running tests/ec/ectest.sh fails with token-only build, because pk11ectest and certutil are not built.  Maybe the test script could be split too or check the existence of those programs?

Comment 3

[Franziskus Kiefer [:franziskus]]

> Maybe the test script could be split too or check the existence of those programs?

Good point! I'll make sure to change the test script before landing so that the script runs the tests only when the binaries are present.

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 8796537 [details] [diff] [review]
fix-boundaries.patch

I've applied this patch locally (hg import --no-commit) and then produced a whitespace-ignore diff (hg diff -w) which makes things much easier to review, because it no longer gives the impression that large blocks of code are changing.

With that -w patch, I see that you're mostly removing things, so that each test program only tests a subset.

This line is apparently wrong, you probably want to call pk11ectest ?
  +PK11_ECTEST_OUT=$(fbectest -n -d 2>&1)

r=kaie if you fix this and what Daiki said

Comment 5

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/0c845c900217050b8ee6e054655ea130d24480a4