1306332 - Setting Max Window Size Hints disables maximize button in VcXsrv

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Donald A. Cupp Jr.]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce:

Connect to a remote Xserver on Windows(VcXsrv).


Actual results:

The window maximize button is disabled.


Expected results:

The maximize button should allow the window to grow to the maximum size of the screen.

Comment 1

[Donald A. Cupp Jr.]

Working with mstange, a patch was created to resolve this issue, but it is unknown if the patch creates other issues.

Comment 2

[Donald A. Cupp Jr.]

Attachment: Don't set Max Window Size Hint

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1306332 - Don't set a maximum size on the native window if SetSizeConstraints is called with magical "unconstrained" values.

Review commit: https://reviewboard.mozilla.org/r/82164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82164/

Comment 4

[Markus Stange [:mstange]]

Donald, I've made a few changes to the patch. Can you test this version and check whether it still fixes your problem?

Comment 5

[Donald A. Cupp Jr.]

Markus, This patch does what I need it to do in it's new form. Tested:Works

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8796259 [details]
Bug 1306332 - Don't set a maximum size on the native window if SetSizeConstraints is called with magical "unconstrained" values.

https://reviewboard.mozilla.org/r/82164/#review81164

Looks good, thanks!

::: widget/gtk/nsWindow.cpp:1049
(Diff revision 1)
> +          hints |= GDK_HINT_MIN_SIZE;
> +        }
> +        if (aConstraints.mMaxSize != LayoutDeviceIntSize(NS_MAXSIZE, NS_MAXSIZE)) {
> +          hints |= GDK_HINT_MAX_SIZE;

This file uses 4 space indents, so please follow that.

::: widget/gtk/nsWindow.cpp:1051
(Diff revision 1)
>  
> -        uint32_t hints = GDK_HINT_MIN_SIZE | GDK_HINT_MAX_SIZE;
> +        uint32_t hints = 0;
> +        if (aConstraints.mMinSize != LayoutDeviceIntSize(0, 0)) {
> +          hints |= GDK_HINT_MIN_SIZE;
> +        }
> +        if (aConstraints.mMaxSize != LayoutDeviceIntSize(NS_MAXSIZE, NS_MAXSIZE)) {

Please wrap to stay with 80 columns.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b941c91a86a
Don't set a maximum size on the native window if SetSizeConstraints is called with magical "unconstrained" values. r=karlt

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b941c91a86a