Closed Bug 1306366 Opened 4 years ago Closed 4 years ago
mach eslint no longer accepts --no-ignore as a parameter
58 bytes, text/x-review-board-request
STR: * Get the latest from mozilla-central * run ./mach eslint devtools/client/shared/test/browser_css_color.js --no-ignore Expected results: * The file should be linted, bypassing the ignore rule. Actual results: * This warning message is received: "warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override. (eslint)" I'm not sure on the exact regression range, but I have a checkout from September 1st where this still works.
Try: ./mach lint --linter eslint devtools/client/shared/test/browser_css_color.js --no-ignore As of bug 1258341 |mach eslint| is just a shim to |mach lint|, but for some reason extra_args don't seem to be working anymore :/. Let's keep this open for now as there is still a bug here.. though ideally I would like to remove |mach eslint| altogether and have people set up a mach alias for it if they want.
Thanks! I'll just do a bash alias on my end.
This should take care. Forwarding the extra arguments as argv will have them considered correctly by the dispatcher.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Comment on attachment 8801083 [details] Bug 1306366 - mach eslint no longer accepts --no-ignore as a parameter. https://reviewboard.mozilla.org/r/85896/#review84510 Thanks for digging into this!
Attachment #8801083 - Flags: review?(ahalberstadt) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/68f7f7949d17 mach eslint no longer accepts --no-ignore as a parameter. r=ahal
You need to log in before you can comment on or make changes to this bug.