1306394 - No Line border contour around top of Tabs (Windows 10)

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Armando Esteves]

Attachment: thundertab1.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

Thunderbird (latest and recent versions) in Windows 10. No Line border contour around top of Tabs (it seems to work in Windows 7 and abouts).


Actual results:

Tabs are NOT visible (or get "wash-out") if a white/clear background color and/or theme is used.


Expected results:

Tabs should be visible at any background color and/or theme through line border contour.

Comment 1

[Richard Marti (:Paenglab)]

How have you made the toolbar and titlebar white? Through userChrome.css? If yes try to use this in userChrome.css:

#tabs-toolbar {
  --tabBackgroundImage: url("chrome://messenger/skin/tabs/background-start.png"),
                        url("chrome://messenger/skin/tabs/background-middle.png"),
                        url("chrome://messenger/skin/tabs/background-end.png") !important;
}

Comment 2

[Armando Esteves]

No chrome.css used, but regular Mozilla Theme addon (in this case, Abstract Black). 

To note, this is consistent to any background, including regular default theme. While using default theme, the Tabs can be observed due overlap of white/gray shade of Tab on top of blue background. In this scenario, it also can be noticed that at default theme there is NO "line border contour around Tabs". Thus, when background is white, it matches and blends with Tab, and Tabs no longer can be identified. 

Through parallel testing to different PCs, this seems consistent when in Windows 10 OS platform. Same Thunderbird versions (45 & 49b1) at older Windows OS seems to behave as expected, and even at white/clear background the Tabs can easily be identified due to line contour at top of Tabs.

Comment 3

[Armando Esteves]

Just noticed that older TB at older Windows OS also have problems: ONLY Active Tab is clearly identified and line border contour around Tab; other Tabs disappeared and blend color with background (even at Default theme; also tested at Safe Mode, no other addons). All other Tabs ONLY at mouse rollover.

Summary:
 - TB Windows 10: no line border contour around Tab (active or not)
 - TB Windows 7 (or abouts): active Tab have border, other Tabs not (unless mouse rollover)

Comment 4

[Jorg K (CEST = GMT+2)]

Sorry, we don't deal with problems caused by third-party themes. Please contact the theme author.

Comment 5

[Armando Esteves]

Its unfortunate that, besides my carefulness to testing the issue (prior to report at different modes, Windows versions, and different machines) and bug report description, my posting was NOT read with attention. As posted above:

 - Issue notice at ANY instance, default theme included (just more obvious with clear/white background)
 - Thunderbird also tested at SAFE MODE, with ALL addons turned off (as to avoid any add-on interference)
 - Consistent at diverse Windows OS versions (default theme included; more persistent at Windows 10)

Please, review.

Comment 6

[Richard Marti (:Paenglab)]

"Abstract Black" is a LW-theme not a full theme. I also don't like how it looks on Win10. We shouldn't follow here FX and show the border.

I'm on it...

Comment 7

[Richard Marti (:Paenglab)]

Attachment: bug1306394.patch

This gives the border back on Win10 with LW-themes enabled.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Patch applied with light LW-theme

For easier review a screenshot with patch applied.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8796566 [details] [diff] [review]
bug1306394.patch

r=jorgk
Looks reasonable. I didn't try it since my Windows 10 machines is 1800 km away now.

(Let me land this with bug 1306630 later on, OK?, no need to put "checkin needed.")

Comment 10

[Armando Esteves]

Thank you all for bug acknowledgement and prompt assessment to the issue.

Much improvement as noticed from attachment (active Tab can now be observed in Win10).

Also as noticed from attachment, Tabs behaviour in Win10 seems now same as observed in "older" Windows (Win7 or abouts), which is Active Tab gets line border and well defined even at white background. Other Tabs not defined (in my Win7, other Tabs gets border defined at mouse rollover).

Not sure if this "rollover" is a bug, an issue or regular behaviour. But to notice from attachment that, other than the active Tab, other Tabs (Options, and Add-ons Manager in this case) have icons, Tab titles and "X" cross close Tab buttons floating against the background.

Comment 11

[Richard Marti (:Paenglab)]

The "rollover" is a regular behaviour. Inactive tabs aren't showing a border to give better focus to the active tab.

Comment 12

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/a29ba4542bba
(landed that since I needed something to land to rerun tests.)

Comment 13

[Armando Esteves]

Thanks Richard et Jorg for the prompt response and resolution.

As a long term user, please let me know if I can be of assistance.


Go Mozilla... take over Tokyo and the World!

Comment 14

[Richard Marti (:Paenglab)]

Comment on attachment 8796566 [details] [diff] [review]
bug1306394.patch

[Approval Request Comment]
User impact if declined: Almost not visible tabs with light LW-themes
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 8796566 [details] [diff] [review]
bug1306394.patch

C-A (TB 51): https://hg.mozilla.org/releases/comm-aurora/rev/799076558f4d
C-B (TB 50): https://hg.mozilla.org/releases/comm-beta/rev/56f333e07eb6

Comment 16

[Armando Esteves]

Border contour indeed fixed, but a minor cosmetic.

The top regular straight border seems more "dense/bold" than the contour around tab (Windows 10, TB v50b1) and causes minor distraction as both lines do not seem as a continue line around all border.

In Windows-7 (TB v49), the regular straight border seems thinner and seems to smoothly continue around tab.

Comment 17

[Kent James (:rkent)]

Comment on attachment 8796566 [details] [diff] [review]
bug1306394.patch

https://hg.mozilla.org/releases/comm-esr45/rev/0aadb68a8cf1