1306445 - Remove the mobile bookmarks anno from the mobile root

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Lina Butler [:lina]]

Once users have some time to migrate to the new mobile root (2-3 cycles after bug 1302901 lands), we can remove the anno, and the code from `BookmarkJSONUtils` to move mobile folder contents into the root.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1306445 - Remove the mobile bookmarks annotation from the mobile root as it is no longer required.

Review commit: https://reviewboard.mozilla.org/r/229506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229506/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8960763 [details]
Bug 1306445 - Remove the mobile bookmarks annotation from the mobile root as it is no longer required.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229506/diff/1-2/

Comment 3

[Mark Banner (:standard8)]

Marco, just a thought, should I combine this with bug 1444094 and save another round of migration? (Since I assume we'll want to make sure the old places/excludeFromBackup annotations have all been removed).

Comment 4

[Marco Bonardo [:mak]]

Would it be risky if some profiles would reain this anno indefinitely, or just for some more time?
I'm mostly guessing if we could do the removal in maintenance, rather than on migration.
https://searchfox.org/mozilla-central/rev/b29daa46443b30612415c35be0a3c9c13b9dc5f6/toolkit/components/places/PlacesDBUtils.jsm#244
Migration should be used if having those around may cause a risk to the user's data, or if the orphans take a large chunk of space, off-hand it doesn't sound the case?

Comment 5

[Mark Banner (:standard8)]

(In reply to Marco Bonardo [::mak] from comment #4)
> Would it be risky if some profiles would reain this anno indefinitely, or
> just for some more time?

Discussing with Kit over irc, this annotation doesn't get synced, and there should only be one of them. Given that is one record in each of two tables, that doesn't seem too expensive. New profiles won't have it.

It also feels like having it in potentially daily maintenance isn't really necessary.

If in the future, we remove annotations, then we could drop it at that time, or if we find some other reason that we need to maintain the annotations table, we could drop it then.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8960763 [details]
Bug 1306445 - Remove the mobile bookmarks annotation from the mobile root as it is no longer required.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229506/diff/2-3/

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8960763 [details]
Bug 1306445 - Remove the mobile bookmarks annotation from the mobile root as it is no longer required.

https://reviewboard.mozilla.org/r/229506/#review235758

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f371354d1364
Remove the mobile bookmarks annotation from the mobile root as it is no longer required. r=mak

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f371354d1364