If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

Cloud Services
Operations: Deployment Requests
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mythmon, Assigned: relud)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
Please deploy Normandy v20.

# Major changes

* Correctly sets Accept header for compatibility with Firefox 43

# Commit log

$ git log v18..v19 --pretty=format:"%h %s"

3a2962c Merge pull request #278 from mythmon/actions-accept-json
1540dc8 Move fetchMock.restore() to beforeAfter
c92bed0 self-repair: Send Accept: application/json when fetching action data

Thanks!
Testing on regular nodes on staging passed

(venv) ~/m/normandy ((v20)) $ py.test --server=https://normandy.stage.mozaws.net -v contract-tests/
========================================================= test session starts =========================================================
platform darwin -- Python 3.5.2, pytest-3.0.2, py-1.4.31, pluggy-0.3.1 -- /Users/chartjes/mozilla/normandy/venv/bin/python3.5
cachedir: .cache
django settings: normandy.settings (from ini file)
rootdir: /Users/chartjes/mozilla/normandy, inifile: pytest.ini
plugins: django-2.9.1, mock-0.11.0, testrail-0.0.9
collected 15 items

contract-tests/test_api.py::test_expected_action_types PASSED
contract-tests/test_api.py::test_console_log PASSED
contract-tests/test_api.py::test_show_heartbeat PASSED
contract-tests/test_api.py::test_recipe_signatures PASSED
contract-tests/test_api.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_heartbeat.py::test_heartbeat_is_ok PASSED
contract-tests/test_heartbeat.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/recipe/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/action/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/recipe/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/action/] PASSED

Testing on admin nodes passed, test_no_vary_cookie tests skipped as expected

(venv) ~/m/normandy ((v20)) $ py.test --server=https://normandy-admin.stage.mozaws.net -v contract-tests/
========================================================= test session starts =========================================================
platform darwin -- Python 3.5.2, pytest-3.0.2, py-1.4.31, pluggy-0.3.1 -- /Users/chartjes/mozilla/normandy/venv/bin/python3.5
cachedir: .cache
django settings: normandy.settings (from ini file)
rootdir: /Users/chartjes/mozilla/normandy, inifile: pytest.ini
plugins: django-2.9.1, mock-0.11.0, testrail-0.0.9
collected 15 items

contract-tests/test_api.py::test_expected_action_types PASSED
contract-tests/test_api.py::test_console_log PASSED
contract-tests/test_api.py::test_show_heartbeat PASSED
contract-tests/test_api.py::test_recipe_signatures PASSED
contract-tests/test_api.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_heartbeat.py::test_heartbeat_is_ok PASSED
contract-tests/test_heartbeat.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/recipe/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/action/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair] SKIPPED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair/] SKIPPED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/recipe/] SKIPPED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/action/] SKIPPED

Verified the follow recipes on staging behaved as expected via the control UI:

* US Geolocation Test
* Locale filtering test
* Mountain Dew Survey
* Message with a Button Test
* Basic Survey Prompt

QA approves tag v20 for deployment to production
:relud, please let me know when v20 is in staging since apparently I tested v19 again.
Flags: needinfo?(dthorn)
(Assignee)

Comment 3

a year ago
stage is up
Flags: needinfo?(dthorn)
Contract and behaviour tests passed on staging end points

(venv) ~/m/normandy ((v20)) $ py.test --server=https://normandy.stage.mozaws.net -v contract-tests/
========================================================= test session starts =========================================================
platform darwin -- Python 3.5.2, pytest-3.0.2, py-1.4.31, pluggy-0.3.1 -- /Users/chartjes/mozilla/normandy/venv/bin/python3.5
cachedir: .cache
django settings: normandy.settings (from ini file)
rootdir: /Users/chartjes/mozilla/normandy, inifile: pytest.ini
plugins: django-2.9.1, mock-0.11.0, testrail-0.0.9
collected 15 items

contract-tests/test_api.py::test_expected_action_types PASSED
contract-tests/test_api.py::test_console_log PASSED
contract-tests/test_api.py::test_show_heartbeat PASSED
contract-tests/test_api.py::test_recipe_signatures PASSED
contract-tests/test_api.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_heartbeat.py::test_heartbeat_is_ok PASSED
contract-tests/test_heartbeat.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/recipe/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/action/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/recipe/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/action/] PASSED

(venv) ~/m/normandy ((v20)) $ py.test --server=https://normandy-admin.stage.mozaws.net -v contract-tests/
========================================================= test session starts =========================================================
platform darwin -- Python 3.5.2, pytest-3.0.2, py-1.4.31, pluggy-0.3.1 -- /Users/chartjes/mozilla/normandy/venv/bin/python3.5
cachedir: .cache
django settings: normandy.settings (from ini file)
rootdir: /Users/chartjes/mozilla/normandy, inifile: pytest.ini
plugins: django-2.9.1, mock-0.11.0, testrail-0.0.9
collected 15 items

contract-tests/test_api.py::test_expected_action_types PASSED
contract-tests/test_api.py::test_console_log PASSED
contract-tests/test_api.py::test_show_heartbeat PASSED
contract-tests/test_api.py::test_recipe_signatures PASSED
contract-tests/test_api.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_heartbeat.py::test_heartbeat_is_ok PASSED
contract-tests/test_heartbeat.py::testrail <- venv/lib/python3.5/site-packages/pytest_testrail/plugin.py PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/en-US/repair/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/recipe/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_redirects[/api/v1/action/] PASSED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair] SKIPPED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/en-US/repair/] SKIPPED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/recipe/] SKIPPED
contract-tests/test_performance.py::TestHotPaths::test_no_vary_cookie[/api/v1/action/] SKIPPED

Verified the follow recipes on staging behaved as expected via the control UI:

* US Geolocation Test
* Locale filtering test
* Mountain Dew Survey
* Message with a Button Test
* Basic Survey Prompt

QA approves tag v20 for deployment to production
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.