1306466 - Intermittent browser/base/content/test/urlbar/browser_urlbarEnterAfterMouseOver.js | Uncaught exception - at resource://gre/modules/History.jsm:504 - TypeError: date: Thu Sep 29 2016 04:12:37 GMT-0800 (Pacific Standard Time) cannot be a future date

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=4216851&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win32-debug/1475142680/autoland_xp_ix-debug_test-mochitest-browser-chrome-2-bm126-tests1-windows-build49.txt.gz

Comment 1

[Marco Bonardo [:mak]]

This is probably due to the changes in bug 1272686

History doesn't like future dates, but in this case doesn't look like we are adding a future date, but sounds like there may be a skew, maybe due to timers resolution?
We should probably add a 16ms skew to the check here:
http://searchfox.org/mozilla-central/rev/d1276b5b84e6cf7991c8e640b5e0ffffd54575a6/toolkit/components/places/History.jsm#503

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1306466 - Add timers resolution skew to History future date check, to avoid intermittent failures.

Review commit: https://reviewboard.mozilla.org/r/82342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82342/

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8796490 [details]
Bug 1306466 - Add timers resolution skew to History future date check, to avoid intermittent failures.

https://reviewboard.mozilla.org/r/82342/#review81088

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43c03bc69208
Add timers resolution skew to History future date check, to avoid intermittent failures. r=adw

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/43c03bc69208

Comment 6

[Intermittent Failures Robot]

1 failures in 949 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-esr52: 1

Platform breakdown:
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306466&startday=2017-08-14&endday=2017-08-20&tree=all

Comment 7

[Ivan]

Thank you very much. I found the answers very helpful. I always try to read the answers to different questions. And if I don't find an answer, I write to technical support. I recently won $2,000 on https://legjobbkaszinok.net/ and wanted to withdraw the money to my card. But it didn't work, I kept getting an error. I wrote to technical support and solved the problem.