Add a diff+commit submit button to some text areas in tc-tools
Categories
(Taskcluster :: UI, enhancement)
Tracking
(Not tracked)
People
(Reporter: bstack, Assigned: ss77995ss, Mentored)
Details
Comment 1•9 years ago
|
||
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Updated•7 years ago
|
Updated•6 years ago
|
Comment 18•6 years ago
•
|
||
This is still valid but should be done in the new UI (not tc-tools).
Assignee | ||
Comment 19•6 years ago
|
||
Hi, is this bug still available? I'm interested in working on this one, thanks!
Updated•6 years ago
|
Comment 20•6 years ago
|
||
I think I agree with the approach in https://bugzilla.mozilla.org/show_bug.cgi?id=1306494#c10. We actually already do something similar in https://taskcluster-ui.herokuapp.com/hooks/garbage/abc456 where we have a "WRITE" and "PREVIEW" tab for markdown text. We could use something similar for displaying the diff.
Assignee | ||
Comment 21•6 years ago
|
||
Comment 22•5 years ago
•
|
||
There is a PR that's almost ready to be merged. Before we do, would it make more sense to show the expanded scopes diff rather than the scopes diff after making changes to the list of scopes?
Reporter | ||
Comment 23•5 years ago
|
||
Good question. I think limiting it to exactly what you're editing makes sense for now? Maybe we could show both for scopes diffs?
Honestly I think let's do whichever is easier for now and we can iterate on it later if we want to improve! Nice work to both of you!
Comment 24•5 years ago
|
||
Completed in https://github.com/taskcluster/taskcluster/commit/d999bf75e74ebe8db4b1872b61a6dcfb8aa03e9d. A big thank you to Sean for their hard work \o/
Comment 25•5 years ago
|
||
How cool is that!
Description
•