Closed
Bug 1306616
Opened 8 years ago
Closed 8 years ago
remove nsWritingIterator<T>::write
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(2 files)
1.68 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
2.02 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
Iterators shouldn't have this sort of functionality; it should be relegated
somewhere else instead.
![]() |
Assignee | |
Comment 1•8 years ago
|
||
I wrote this before realizing I could write the next part, but I think this is
a bit of a simplification regardless.
Attachment #8796552 -
Flags: review?(erahm)
![]() |
Assignee | |
Comment 2•8 years ago
|
||
Iterators shouldn't have methods like write(); if you need to write to
an iterator, that logic should be handled by something outside of the
iterator...which also explains why we have a specialization of
nsCharTraits<nsWritingIterator<T>>. The HTML parser wants this for its
own reasons, so we have to make sure it continues to work.
Attachment #8796553 -
Flags: review?(erahm)
Updated•8 years ago
|
Attachment #8796552 -
Flags: review?(erahm) → review+
Updated•8 years ago
|
Attachment #8796553 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5b932a4fad
part 1 - don't use write() method of nsWritingIterator in nsReadableUtils; r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7d19f4aed9
part 2 - remove nsWritingIterator<T>::write; r=erahm
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f5b932a4fad
https://hg.mozilla.org/mozilla-central/rev/5c7d19f4aed9
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•