Iterators shouldn't have this sort of functionality; it should be relegated somewhere else instead.
I wrote this before realizing I could write the next part, but I think this is a bit of a simplification regardless.
Attachment #8796552 - Flags: review?(erahm)
Iterators shouldn't have methods like write(); if you need to write to an iterator, that logic should be handled by something outside of the iterator...which also explains why we have a specialization of nsCharTraits<nsWritingIterator<T>>. The HTML parser wants this for its own reasons, so we have to make sure it continues to work.
Attachment #8796553 - Flags: review?(erahm)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5b932a4fad part 1 - don't use write() method of nsWritingIterator in nsReadableUtils; r=erahm https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7d19f4aed9 part 2 - remove nsWritingIterator<T>::write; r=erahm
You need to log in before you can comment on or make changes to this bug.