1306616 - remove nsWritingIterator<T>::write

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

Iterators shouldn't have this sort of functionality; it should be relegated
somewhere else instead.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - don't use write() method of nsWritingIterator in nsReadableUtils

I wrote this before realizing I could write the next part, but I think this is
a bit of a simplification regardless.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - remove nsWritingIterator<T>::write

Iterators shouldn't have methods like write(); if you need to write to
an iterator, that logic should be handled by something outside of the
iterator...which also explains why we have a specialization of
nsCharTraits<nsWritingIterator<T>>.  The HTML parser wants this for its
own reasons, so we have to make sure it continues to work.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5b932a4fad
part 1 - don't use write() method of nsWritingIterator in nsReadableUtils; r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7d19f4aed9
part 2 - remove nsWritingIterator<T>::write; r=erahm

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1f5b932a4fad
https://hg.mozilla.org/mozilla-central/rev/5c7d19f4aed9