Closed Bug 1306617 Opened 5 years ago Closed 5 years ago

use nsDependentAtomString for Gecko_AtomEquals* functions

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

This change should avoid a little bit of memory traffic, as we don't
have to copy the string data out of the atom or atomically increment the
refcount on the atom's string buffer.
I'm pretty sure this change is safe, but I'm not really set up to test it
myself.  What's the best way to make sure this works?  (Or do you just want me
to YOLO-land the patch without testing because it looks safe?)
Attachment #8796554 - Flags: review?(bobbyholley)
Comment on attachment 8796554 [details] [diff] [review]
use nsDependentAtomString for Gecko_AtomEquals* functions

Review of attachment 8796554 [details] [diff] [review]:
-----------------------------------------------------------------

If you want to test it on stylo, clone hg.mozilla.org/incubator/stylo, make the change, and then push to try with:

try: -b o -p linux64 -u reftest-stylo[x64] -t none --tag reftest-stylo --rebuild 2

I won't insist though if you think this is safe.

rs=me
Attachment #8796554 - Flags: review?(bobbyholley) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fb52fae33da
use nsDependentAtomString for Gecko_AtomEquals* functions; r=bholley
https://hg.mozilla.org/mozilla-central/rev/9fb52fae33da
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.