1306644 - Avoid unnecessary sync IPC round trip for TakeFocusForClickFromTap

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now the PBrowser::HandleTap message is sent from TabParent to TabChild and then if the tap type is eSingleTap, TabChild turns around and sends a TakeFocusForClickFromTap message back to the parent via PRenderFrame. This seems like a wasted sync IPC message since TabParent could just do this directly before sending the HandleTap message to the child. That should be equivalent.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1306644 - Have TabParent call TakeFocusForClickFromTap rather than doing it over a sync IPC roundtrip.

Review commit: https://reviewboard.mozilla.org/r/82400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82400/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8796600 [details]
Bug 1306644 - Have TabParent call TakeFocusForClickFromTap rather than doing it over a sync IPC roundtrip.

https://reviewboard.mozilla.org/r/82400/#review81036

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Had to rebase around bug 1302736, which added a eSecondTap type as well which also does the TakeFocusForClickFromTap dance. The rebase was straightforward enough so I'm just going to land it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eb7d99a0bb2
Have TabParent call TakeFocusForClickFromTap rather than doing it over a sync IPC roundtrip. r=dvander

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9eb7d99a0bb2