1306719 - Build of MemoryProtectionExceptionHandler.cpp fails on Mac OSX when new cpp files added

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Yury Delendik (:yury)]

If couple of new source files added to the js/src/asmjs/ the build fails with:

/Users/yury/Work/mozilla-central/js/src/ds/MemoryProtectionExceptionHandler.cpp:132:25: error: use of undeclared
      identifier 'STDERR_FILENO'
    ssize_t ret = write(STDERR_FILENO, aStr, strlen(aStr) + 1);
                        ^
/Users/yury/Work/mozilla-central/js/src/ds/MemoryProtectionExceptionHandler.cpp:505:5: error: unknown type name
      'Thread'
    Thread handlerThread;
    ^

The MemoryProtectionExceptionHandler.cpp was pushed to the different unified build group (and looks like we don't test non-unified build for Mac OSX)

Comment 1

[Yury Delendik (:yury)]

Attachment: fix-MemoryProtectionExceptionHandler.patch

(I did not check the Windows yet, which might have the same issue)

Comment 2

[Emanuel Hoogeveen [:ehoogeveen]]

Comment on attachment 8796698 [details] [diff] [review]
fix-MemoryProtectionExceptionHandler.patch

Erk, more non-unified bustage? Sorry about that.

I don't have Mac to compile this on locally, and we don't have a non-unified build in automation for OSX, but if this fixes compilation for you then it's fine.

Just did a non-unified build on Windows (was easier than I expected), confirmed nothing is missing there.

Comment 3

[Yury Delendik (:yury)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec538f46ccaf50ebec1e1bdbc319ba28b8205219

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a68cafd32e5
Fix unified build compilation of MemoryProtectionExceptionHandler.cpp. r=ehoogeveen

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5a68cafd32e5