1306722 - Make l10n nightly builds in builds-4hr use 40 character SHA revision

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

Searching builds-4hr for jobs using the legacy revision format found:
https://bug1306707.bmoattachments.org/attachment.cgi?id=8796694

Treeherder would like to soon drop support for 12 character SHAs, so it would be helpful if l10n nightlies were switched to them.

Justin, could you help?

Thanks :-)

Comment 1

[Justin Wood (:Callek)]

I'm not sure how to process this atm. (nor how to easily prioritize) -- whats your timeline for the obsolescence of this codepath?

(as in, at what point will these 12-char SHAs no longer appear on treeherder)

Comment 2

[Ed Morley [:emorley]]

Ideally within the next month or two :-)

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Probably caused by https://dxr.mozilla.org/mozilla-central/rev/d26ac63f1b81c3fce35448a7c502e95e0b5c56c0/testing/mozharness/mozharness/mozilla/building/buildbase.py#1202

Comment 4

[Ed Morley [:emorley]]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Probably caused by
> https://dxr.mozilla.org/mozilla-central/rev/
> d26ac63f1b81c3fce35448a7c502e95e0b5c56c0/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#1202

Will, don't suppose you have a mozilla-central checkout around and set up with reviewboard etc? If so, would you mind making the one line change here? :-)

Comment 5

[Justin Wood (:Callek)]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Probably caused by
> https://dxr.mozilla.org/mozilla-central/rev/
> d26ac63f1b81c3fce35448a7c502e95e0b5c56c0/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#1202

I'm less sure about this, but should be a safe/easy fix, I'll patch this up...

Comment 6

[Justin Wood (:Callek)]

Attachment: Bug 1306722 - Make l10n nightly builds in builds-4hr use 40 character SHA revision.

Review commit: https://reviewboard.mozilla.org/r/91464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91464/

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8808716 [details]
Bug 1306722 - Make l10n nightly builds in builds-4hr use 40 character SHA revision.

https://reviewboard.mozilla.org/r/91464/#review91380

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a0c37ab1352
Make l10n nightly builds in builds-4hr use 40 character SHA revision. r=nthomas

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a0c37ab1352

Comment 10

[Ed Morley [:emorley]]

Tomcat, I don't suppose you could do a massive favour and backport this to aurora too? :-)

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/36e95af87c4c1c9a56967a52a1aa6e0396db8230 done :)

Comment 12

[Ed Morley [:emorley]]

Many thanks Tomcat!