1306733 - Crash in @0x0 | nsTimerEvent::Run

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-da4f6534-a979-434e-8b80-6a9572160930.
=============================================================

Low volume crash that started with the 9-29 Nightly. So far it's the #19 top crash for that Nightly with 8 crashes.

Byron, since this crash appeared right after bug 1157323 landed, do you think this is a regression from that bug?

Comment 1

[Byron Campen [:bwc]]

I think that bug 1157323 has uncovered some pre-existing problem here. But, I'm not seeing the smoking gun. Let me try a fix.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1306733: Don't crash on release builds if mTimer isn't set here.

Review commit: https://reviewboard.mozilla.org/r/82478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82478/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8796730 [details]
Bug 1306733: Don't crash on release builds if mTimer isn't set here.

https://reviewboard.mozilla.org/r/82478/#review81760

We're going to need to uplift this, correct?

Comment 4

[Byron Campen [:bwc]]

No, that rewrite landed in 52.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/067c15e2620f
Don't crash on release builds if mTimer isn't set here. r=froydnj

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/067c15e2620f

Comment 7

[Byron Campen [:bwc]]

Patch does not seem to have helped. Stack must be misleading somehow. Investigating further.

Comment 8

[Byron Campen [:bwc]]

This might just be a dupe of bug 1307688, actually.

Comment 9

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f89ca7d6cafb

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06f56f361689

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01bb0f443c76

Comment 12

[Nicholas Nethercote [inactive]]

This is the #7 top crash in Nightly 20161216030207. It's occurred 111 times in the past 7 days, on both Nightly 53 and Aurora 52.

Byron, any more ideas?

Comment 13

[Byron Campen [:bwc]]

It could simply be that bug 1285384 and/or bug 1290894 is causing this. I had started investigating a workaround, but got swamped by other stuff.

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9201ed84dc06

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature '@0x0 | nsTimerEvent::Run':
 - nightly (version 54): 147 crashes from 2017-01-23.
 - aurora  (version 53): 149 crashes from 2017-01-23.
 - beta    (version 52): 2613 crashes from 2017-01-23.
 - release (version 51): 3 crashes from 2017-01-16.
 - esr     (version 45): 0 crashes from 2016-08-10.

Crash volume on the last weeks (Week N is from 02-06 to 02-12):
            W. N-1  W. N-2  W. N-3  W. N-4  W. N-5  W. N-6  W. N-7
 - nightly      75      64
 - aurora      102       6
 - beta       1714       0
 - release       1       1       0
 - esr           0       0       0       0       0       0       0

Affected platform: Windows

Crash rank on the last 7 days:
           Browser   Content   Plugin
 - nightly #234      #17
 - aurora  #90       #6
 - beta    #30       #4
 - release
 - esr

Comment 16

[Byron Campen [:bwc]]

Looking at the build ids, it would appear that the landing of bug 1328643 fixed this.

Comment 17

[Byron Campen [:bwc]]

The uplift of bug 1328643 to aurora has stopped this crash there also. No crashes on b5 either.