1306768 - Convert android tasks to run-task

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

Follow-up work from bug 1289249.

Comment 1

[Gregory Szorc [:gps]]

It's a bit of a rabbit hole. Meh.

Comment 2

[Gregory Szorc [:gps]]

I'm going to take another stab at this.

Comment 3

[Chris Cooper [:coop] (he/him)]

gps: is this still on your radar?

Comment 4

[Gregory Szorc [:gps]]

It most definitely isn't.

This bug may have sorted itself out as part of other refactors over the past year though. I do recall a lot of changes to ho these tasks are executing. But I'm too busy to verify.

needinfo on the Android build expert.

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Gregory Szorc [:gps] from comment #4)
> It most definitely isn't.
> 
> This bug may have sorted itself out as part of other refactors over the past
> year though. I do recall a lot of changes to ho these tasks are executing.
> But I'm too busy to verify.
> 
> needinfo on the Android build expert.

These are all `run-using: mozharness`; see https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/taskcluster/ci/build/android-stuff.yml#29.

This is because they are "build-like" -- they need a source checkout, need a mozconfig, and need to do some Java compilation, which requires some GENERATED_FILES, etc -- _and_ test-like in that they run commands "after the fact" in order to do some static evaluation.

When I did the work, the only way to do things that were "build-like" was to use mozharness.  That's no longer true -- the android-gradle-dependencies task is "build-like" but is `run-using: toolchain-script`, see https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/taskcluster/ci/toolchain/linux.yml#351.

Under the hood these are all using run-task, IIUC, so this might just be done.

coop -- your thoughts?

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to Nick Alexander :nalexander from comment #5)
> Under the hood these are all using run-task, IIUC, so this might just be
> done.
> 
> coop -- your thoughts?

I don't know enough about the internals to answer knowledgeably.  Redirecting to :dustin.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

I was afraid of that.

Nick's done a *bunch* of work on the Android build tasks, and they're in pretty good shape.  And yes, whether mozharness or toolchain-script, it's all run-task in the end.

So, I'd call this done.  If there are specific problems this is causing, either they're different bugs or we'll file bugs when we notice them.