Closed Bug 1306786 Opened 8 years ago Closed 8 years ago

Intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js | shown callback was triggered -

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Type:
defect

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bytesized)

References

Details

(Keywords: intermittent-failure, Whiteboard: Attachment 8799877 already checked in)

Attachments

(2 files)

Bug 1306786 - Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js
58 bytes, text/x-review-board-request
enndeakin
: review+
bytesized
: checkin+
Details
fix_popupNotification_4.patch
2.42 KB, patch
enndeakin
: review+
cbook
: checkin+
Details | Diff | Splinter Review 
Hi Kirk, this is a frequent intermittent failure on Windows 8x 64, see https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-09-15&endday=2016-10-08&tree=trunk and looks like a regression from bug 1206133.
Blocks: 1206133
Component: General → Notifications and Alerts
Flags: needinfo?(ksteuber)
Priority: -- → P1
Product: Firefox → Toolkit
I'll take a look at it. I think I can fix this pretty quickly.
Assignee: nobody → ksteuber
Flags: needinfo?(ksteuber)
Attachment #8799877 - Flags: review?(enndeakin)
Comment on attachment 8799877 [details]
Bug 1306786 - Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js

https://reviewboard.mozilla.org/r/84952/#review83508

::: testing/mochitest/browser-test.js:609
(Diff revision 1)
>          let shutdownCleanup = aCallback => {
>            Cu.schedulePreciseShrinkingGC(() => {
>              // Run the GC and CC a few times to make sure that as much
>              // as possible is freed.
>              let numCycles = 3;
> -            for (i = 0; i < numCycles; i++) {
> +            for (let i = 0; i < numCycles; i++) {

This was fixed in bug 1308998.
Comment on attachment 8799877 [details]
Bug 1306786 - Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js

https://reviewboard.mozilla.org/r/84952/#review83510
Attachment #8799877 - Flags: review?(enndeakin) → review+
Removed code change that was already made in Bug 1308998. Carrying forwards r+.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac765277e2cb
Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js r=enndeakin+6102
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ac765277e2cb
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
I've got to somehow teach myself not to be hopeful about intermittent-failure fixes, the letdown is too severe. It's not actually fixed.

This happens 99% on Win8, and inconveniently frequently within Win8 runs on PGO builds, so to have caught whether or not it was fixed your try run only doing Win7 tests would have probably needed two or three hundred runs if you had done https://wiki.mozilla.org/ReleaseEngineering/TryChooser#What_if_I_want_PGO_for_my_build to build PGO, and somewhere close to infinite runs to have hit it without PGO.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

        Attachment #8803965 -
        Flags: review?(enndeakin)

    
  

        Attachment #8803965 -
        Flags: review?(enndeakin) → review+
Keywords: checkin-needed
Whiteboard: Attachment 8799877 already checked in

        Attachment #8799877 -
        Flags: checkin+

        Attachment #8803965 -
        Flags: checkin?

    
    

    
  
Comment on attachment 8803965 [details] [diff] [review]
fix_popupNotification_4.patch

will do this during checkin-needed tasks

        Attachment #8803965 -
        Flags: checkin? → checkin+

    
    

    
  
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/306ddd0b5b39
Fix intermittent test failure in browser/base/content/test/popupNotifications/browser_popupNotification_4.js. r=enndeakin
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/306ddd0b5b39
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED

    
    

    
      
  

    
    

    
  
This has decreased in frequency since initial report, can someone tell me why this is P1 (Sebastian)?
Flags: needinfo?(aryx.bugmail)

    
    

    
  
The frequency has decreased (actually it has stopped) because the fix got landed, see comment 33 and comment 34. The intermittent report for the last week started before it landed, so this is the reason we still got a report.
Flags: needinfo?(aryx.bugmail)

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: