Intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js | shown callback was triggered -

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Notifications and Alerts
P1
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: bytesized)

Tracking

({intermittent-failure})

unspecified
mozilla52
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed)

Details

(Whiteboard: Attachment 8799877 already checked in)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

10 months ago
treeherder
Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=36806709&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64-pgo/1475210031/mozilla-inbound_win8_64_test_pgo-mochitest-e10s-browser-chrome-1-bm112-tests1-windows-build97.txt.gz

Comment 1

10 months ago
17 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 8
* autoland: 5
* mozilla-central: 2
* fx-team: 2

Platform breakdown:
* windows8-64: 12
* windows7-32-vm: 4
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-01&endday=2016-10-01&tree=all

Comment 2

10 months ago
32 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 14
* autoland: 10
* mozilla-central: 4
* fx-team: 4

Platform breakdown:
* windows8-64: 26
* windows7-32-vm: 4
* windowsxp: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-09-26&endday=2016-10-02&tree=all

Comment 3

10 months ago
16 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 7
* autoland: 4
* fx-team: 3
* mozilla-central: 2

Platform breakdown:
* windows8-64: 15
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-03&endday=2016-10-03&tree=all

Comment 4

10 months ago
28 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 10
* fx-team: 9
* mozilla-inbound: 7
* mozilla-central: 2

Platform breakdown:
* windows8-64: 26
* windowsxp: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-04&endday=2016-10-04&tree=all

Comment 5

10 months ago
19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 9
* autoland: 5
* fx-team: 3
* mozilla-central: 2

Platform breakdown:
* windows8-64: 18
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-05&endday=2016-10-05&tree=all

Comment 6

10 months ago
36 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 14
* mozilla-inbound: 11
* fx-team: 7
* mozilla-central: 4

Platform breakdown:
* windows8-64: 36

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-06&endday=2016-10-06&tree=all

Comment 7

10 months ago
24 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 6
* mozilla-central: 5
* fx-team: 3

Platform breakdown:
* windows8-64: 23
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-07&endday=2016-10-07&tree=all
Hi Kirk, this is a frequent intermittent failure on Windows 8x 64, see https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-09-15&endday=2016-10-08&tree=trunk and looks like a regression from bug 1206133.
Blocks: 1206133
Component: General → Notifications and Alerts
Flags: needinfo?(ksteuber)
Priority: -- → P1
Product: Firefox → Toolkit

Comment 9

10 months ago
18 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 9
* mozilla-central: 4
* fx-team: 3
* mozilla-inbound: 2

Platform breakdown:
* windows8-64: 17
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-08&endday=2016-10-08&tree=all

Comment 10

10 months ago
153 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 56
* mozilla-inbound: 44
* fx-team: 31
* mozilla-central: 22

Platform breakdown:
* windows8-64: 147
* windowsxp: 3
* windows7-32-vm: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-03&endday=2016-10-09&tree=all
(Assignee)

Comment 11

10 months ago
I'll take a look at it. I think I can fix this pretty quickly.
Assignee: nobody → ksteuber
Flags: needinfo?(ksteuber)
(Assignee)

Comment 12

10 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce272de9f9b6

Comment 13

10 months ago
17 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 6
* mozilla-inbound: 4
* mozilla-central: 4
* fx-team: 3

Platform breakdown:
* windows8-64: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-10&endday=2016-10-10&tree=all
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Attachment #8799877 - Flags: review?(enndeakin)

Comment 15

10 months ago
mozreview-review
Comment on attachment 8799877 [details]
Bug 1306786 - Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js

https://reviewboard.mozilla.org/r/84952/#review83508

::: testing/mochitest/browser-test.js:609
(Diff revision 1)
>          let shutdownCleanup = aCallback => {
>            Cu.schedulePreciseShrinkingGC(() => {
>              // Run the GC and CC a few times to make sure that as much
>              // as possible is freed.
>              let numCycles = 3;
> -            for (i = 0; i < numCycles; i++) {
> +            for (let i = 0; i < numCycles; i++) {

This was fixed in bug 1308998.

Comment 16

10 months ago
mozreview-review
Comment on attachment 8799877 [details]
Bug 1306786 - Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js

https://reviewboard.mozilla.org/r/84952/#review83510
Attachment #8799877 - Flags: review?(enndeakin) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 18

10 months ago
Removed code change that was already made in Bug 1308998. Carrying forwards r+.
Keywords: checkin-needed

Comment 19

10 months ago
19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 12
* mozilla-inbound: 5
* fx-team: 2

Platform breakdown:
* windows8-64: 17
* windowsxp: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-11&endday=2016-10-11&tree=all

Comment 20

10 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac765277e2cb
Fix intermittent browser/base/content/test/popupNotifications/browser_popupNotification_4.js r=enndeakin+6102
Keywords: checkin-needed

Comment 21

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ac765277e2cb
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected

Comment 22

10 months ago
19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 10
* autoland: 7
* mozilla-central: 2

Platform breakdown:
* windows8-64: 18
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-12&endday=2016-10-12&tree=all
I've got to somehow teach myself not to be hopeful about intermittent-failure fixes, the letdown is too severe. It's not actually fixed.

This happens 99% on Win8, and inconveniently frequently within Win8 runs on PGO builds, so to have caught whether or not it was fixed your try run only doing Win7 tests would have probably needed two or three hundred runs if you had done https://wiki.mozilla.org/ReleaseEngineering/TryChooser#What_if_I_want_PGO_for_my_build to build PGO, and somewhere close to infinite runs to have hit it without PGO.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 24

9 months ago
80 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 31
* autoland: 29
* mozilla-central: 11
* fx-team: 9

Platform breakdown:
* windows8-64: 77
* windowsxp: 1
* windows7-32-vm: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-10&endday=2016-10-16&tree=all
(Assignee)

Comment 25

9 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e9a7a596ed1
(Assignee)

Comment 26

9 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1badbb107705
(Assignee)

Comment 27

9 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=586c652d96ca
(Assignee)

Comment 28

9 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a81e9accff83
(Assignee)

Comment 29

9 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33947d08d7bb

Comment 30

9 months ago
55 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 23
* autoland: 14
* fx-team: 10
* mozilla-central: 8

Platform breakdown:
* windows8-64: 51
* windows7-32-vm: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-17&endday=2016-10-23&tree=all
(Assignee)

Comment 31

9 months ago
Created attachment 8803965 [details] [diff] [review]
fix_popupNotification_4.patch
Attachment #8803965 - Flags: review?(enndeakin)
Attachment #8803965 - Flags: review?(enndeakin) → review+
(Assignee)

Updated

9 months ago
Keywords: checkin-needed
Whiteboard: Attachment 8799877 already checked in
(Assignee)

Updated

9 months ago
Attachment #8799877 - Flags: checkin+
(Assignee)

Updated

9 months ago
Attachment #8803965 - Flags: checkin?
Comment on attachment 8803965 [details] [diff] [review]
fix_popupNotification_4.patch

will do this during checkin-needed tasks
Attachment #8803965 - Flags: checkin? → checkin+

Comment 33

9 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/306ddd0b5b39
Fix intermittent test failure in browser/base/content/test/popupNotifications/browser_popupNotification_4.js. r=enndeakin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/306ddd0b5b39
Status: REOPENED → RESOLVED
Last Resolved: 10 months ago9 months ago
Resolution: --- → FIXED

Comment 35

9 months ago
18 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 8
* autoland: 6
* mozilla-central: 4

Platform breakdown:
* windows8-64: 18

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306786&startday=2016-10-24&endday=2016-10-30&tree=all
This has decreased in frequency since initial report, can someone tell me why this is P1 (Sebastian)?
Flags: needinfo?(aryx.bugmail)
The frequency has decreased (actually it has stopped) because the fix got landed, see comment 33 and comment 34. The intermittent report for the last week started before it landed, so this is the reason we still got a report.
Flags: needinfo?(aryx.bugmail)
You need to log in before you can comment on or make changes to this bug.