Closed Bug 1306824 Opened 8 years ago Closed 8 years ago

Consolidate /common Firefox assets in /template directory

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: agibson, Assigned: rcmainak)

Details

(Whiteboard: [good first bug]) 

We have two different directories that both contain shared Firefox page assets:

https://github.com/mozilla/bedrock/tree/master/media/img/firefox/template

https://github.com/mozilla/bedrock/tree/master/media/img/firefox/common

We would like to combine these directories, and move everything under /common to /template. We could probably even get rid of `firefox-logo.png` and `firefox-logo-high-res.png` in /common and just use the equivalent that's already in /template.

It looks like the only two pages using the assets in /common and the homepage and /firefox/desktop/tips/ pages.
Whiteboard: [good first bug]
Did someone said "good first bug"??? :D
Thanks, Mainak!
Assignee: nobody → mozilianmainak
Status: NEW → ASSIGNED
I'm wondering if the common/icon-alert.svg is still in use since support for Hello is discontinued.
(In reply to Mainak Roy Chowdhury [:rcmainak] from comment #3)
> I'm wondering if the common/icon-alert.svg is still in use since support for
> Hello is discontinued.

If it's not being used by any pages please remove it. thanks
Hey Alex, is there anyway to check if that image is being used anywhere other manual efforts?
(In reply to Mainak Roy Chowdhury [:rcmainak] from comment #5)
> Hey Alex, is there anyway to check if that image is being used anywhere
> other manual efforts?

Just searching for it in your code editor should be easy enough.
I presume we don't need the common folder anymore since i got rid of the logos in the common folder & moved the icon-alert.svg to template folder? I can't find if the icon-alert.svg is getting used somewhere.
If the icon-alert is not being used anywhere it can be deleted. If a folder is empty there is no need to keep it. Please submit your pull request and we can talk these things through during code review, which is probably a little easier than here in the big. Thanks!
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/4252326260f8cac2a6372f75d62188f1d6ccd4b1
Bug 1306824. Updated to use the logo in template/ instead of the logo in common/ & cleaned up the common directory.

https://github.com/mozilla/bedrock/commit/dbf4c845943cfbe617c5b44c712281b8ab7cc7b4
Merge pull request #4401 from RCMainak/bug_1306824

Bug 1306824 - Consolidate /common Firefox assets in /template directory
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.