push_printurls should use 40 char SHAs for the revision in Treeherder/Perfherder URLs

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emorley, Assigned: gps)

Tracking

(Blocks: 1 bug)

Details

(Reporter)

Description

a year ago
The push_printurls hghook currently uses 12 character rather than 40 character SHAs for the revision in Treeherder & Perfherder URLs.

https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/push_printurls.py#l20

    tip_node = short(repo.changectx(tip).node())
...
        ui.write('  %s/#/jobs?repo=%s&revision=%s\n' % (treeherder_base_url,
                                                        treeherder_repo,
                                                        tip_node))
...
                ui.write('  %s/perf.html#/comparechooser'
                       '?newProject=try&newRevision=%s\n' % (
                           treeherder_base_url, tip_node))
Flags: needinfo?(gps)
(Assignee)

Updated

a year ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
Flags: needinfo?(gps)

Comment 1

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1759fdffd03f
hghooks: use full SHA-1 hash in push_printurls hook
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Blocks: 1311749
You need to log in before you can comment on or make changes to this bug.