"Calendar" window is too narrow to display "edit" BTN

RESOLVED FIXED

Status

Mozilla Localizations
ja / Japanese
RESOLVED FIXED
8 months ago
4 months ago

People

(Reporter: NISHI, Assigned: marsf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(20 attachments, 1 obsolete attachment)

195.17 KB, image/png
Details
311.74 KB, image/png
Details
324.20 KB, image/png
Details
336.65 KB, image/png
Details
1.88 KB, image/png
Details
11.36 KB, application/x-xpinstall
Details
263.73 KB, image/png
Details
344.95 KB, image/png
Details
288.36 KB, image/png
Details
343.38 KB, image/png
Details
673.22 KB, image/png
Details
321.93 KB, image/png
Details
322.48 KB, image/png
Details
322.88 KB, image/png
Details
19.40 KB, application/x-xpinstall
Details
306.97 KB, image/png
Details
340.28 KB, image/png
Details
279.88 KB, image/png
Details
324.32 KB, image/png
Details
691.65 KB, image/png
Details
(Reporter)

Description

8 months ago
Created attachment 8796850 [details]
NG 2016-10-02 0.18.07.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160922113459

Steps to reproduce:

*Sorry,I'm not good at explain in English.
This Thunderbird is 45.3 for Mac(japanese).

1.open "preference" window
2.press "calender" BTN


Actual results:

"edit" BTN is not displayed fully
(but possible press)


Expected results:

width is enough to display "edit" BTN
Component: Untriaged → Preferences
Product: Thunderbird → Calendar
Version: 45 Branch → unspecified
(Reporter)

Updated

8 months ago
OS: Unspecified → Mac OS X
(Reporter)

Updated

8 months ago
OS: Mac OS X → Unspecified
(Reporter)

Updated

8 months ago
Summary: "Calender" window is too narrow to display "edit" BTN → "Calendar" window is too narrow to display "edit" BTN

Comment 1

8 months ago
I think we should move this to Mozilla Localization: ja / Japanese because the width of the preference dialog is specified by the Japanese localization team:
> https://dxr.mozilla.org/l10n-mozilla-release/search?q=prefWindow.style+path:ja-JP-mac
NISHI, please can you add screenshots of the three other tabpanels of the Calendar prefs? It seems one of the other is too wide and the Categories panel width follows only the widest one.
Flags: needinfo?(nishi2015_1107)
(Reporter)

Comment 3

8 months ago
Created attachment 8801040 [details]
NG_General.png
(Reporter)

Comment 4

8 months ago
Created attachment 8801041 [details]
NG_Alarm.png
(Reporter)

Comment 5

8 months ago
Created attachment 8801042 [details]
NG_Display.png
(Reporter)

Comment 6

8 months ago
(In reply to Richard Marti (:Paenglab) from comment #2)
> NISHI, please can you add screenshots of the three other tabpanels of the
> Calendar prefs? It seems one of the other is too wide and the Categories
> panel width follows only the widest one.

I've just attached three screenshots of tabpanels.
These are of Thunderbird 45.4 For Mac(jp).

Richard, can you confirm them ?
(Reporter)

Updated

8 months ago
Flags: needinfo?(nishi2015_1107)
Created attachment 8801213 [details]
timezone.png

I narrowed it down to the Timezone line.
The menulist is very wide because ja-JP adds always the English translation behind the Japanese name. See for example the longest line: https://dxr.mozilla.org/l10n-mozilla-release/rev/40da02dc415031f4f044260b3e9195b2fddb2230/ja-JP-mac/calendar/chrome/calendar/timezones.properties#74

I see three solutions:
1. Remove the English translations. I can't say if this is usable because I can't say if the timezone is readable without it as I don't speak Japanese.
2. Make https://dxr.mozilla.org/l10n-mozilla-release/rev/40da02dc415031f4f044260b3e9195b2fddb2230/ja-JP-mac/mail/chrome/messenger/preferences/preferences.dtd#9 wider.
3. Truncate the calendar-timezone-menulist so it fits in the smaller window. The downside would be not everything is readable.

1. and 2. need to be done by Japanese l10n. 3. could be done by a Lightning developer.

I'm tending to 1. or 2. MakeMyDay, what do you think?
Flags: needinfo?(makemyday)

Comment 8

8 months ago
Thanks Paenglab for digging into this. A fourth option might be to allow resizing the dialog with using current dimensions for minHeigh/minWidth.

But I think we should consult the Japanese localization team on this issue first before considering option 3 (or 4). That said, I'm moving this bug to the Japanse team for now.

Localizer, what do you think here? This is an issue in the current ESR 45 release as well as up to Aurora. Given to [1], appending the Latin names is only happening for Japanse and Korean locales. Maybe you can also cross check and coordinate with the Korean team if you fix this bug at for end.

[1] https://dxr.mozilla.org/l10n-mozilla-release/search?q=pref.timezone.Europe.Berlin&redirect=false
Status: UNCONFIRMED → NEW
Component: Preferences → ja / Japanese
Ever confirmed: true
Flags: needinfo?(makemyday)
Product: Calendar → Mozilla Localizations
QA Contact: l10n-qa
(Assignee)

Comment 9

8 months ago
I think option 2 AND 4 are good to address this issue. However, I don't have Mac environment.

For option 2:
  How much width do you accept on Mac display?
  Current width is 54em, and it will be needed 12em more wider (66em).
(Reporter)

Comment 10

7 months ago
(In reply to Masahiko Imanaka [:marsf] from comment #9)
> I think option 2 AND 4 are good to address this issue. However, I don't have
> Mac environment.
> 
> For option 2:
>   How much width do you accept on Mac display?
>   Current width is 54em, and it will be needed 12em more wider (66em).

May I help you? I hava a MacBook.
If you support me and tell me what I should do,I suppose I can help to solve it.

(Japanese)
不具合の発見者です。当方MacBookを所持しております。
具体的に何をすれば良いかを教えてくだされば、ご協力できるかと。
(Assignee)

Comment 11

7 months ago
(Written in Japanese. This is how to make change and test the customized pref window size.)

NISHI さん

それでは、言語パック内の数値を変更して試していただけますか?

1. まず、次のページから ja-JP-mac.xpi をダウンロードしてください。
  https://archive.mozilla.org/pub/thunderbird/releases/45.4.0/mac/xpi/
2. この xpi ファイルは zip 形式で圧縮されています。適当な場所にアーカイバで展開してください。
3. 設定値の書かれたファイルはこれです。
  /chrome/ja-JP-mac/locale/ja-JP-mac/messenger/preferences/preferences.dtd
4. この 54em のところを 66em くらいに書き換えてください。
  <!ENTITY  prefWindow.styleMac		"width: 54em;">
5. xpi ファイルに元の通り zip 形式で再圧縮してください。xpi のファイル名はなんでも結構です。
6. テスト用の Thunderbird の新規プロファイルを作成してください。プロファイル作成の手順はこの説明を参照してください。
  https://support.mozilla.org/kb/using-multiple-profiles
7. そのプロファイルで Thunderbird を起動し、アドオンマネージャを開いて、この xpi ファイルをドラッグ&ドロップしてインストールしてください。
8. Thunderbird を再起動し、設定ウインドウを開いて、その幅が画面内に収まっているか確認してみてください。

許容される幅は、できるだけ小さいほうが良いです。
画面幅に対して設定ウインドウがどれだけ占めるか、画面全体のスクリーンショットをいただけると助かります。
よろしくお願いします。
(Assignee)

Comment 12

7 months ago
Created attachment 8805098 [details]
Lt4-dialog-fix-patch-0.2.xpi

This is quick workaround add-on for end-users.

Just removed Japanese localization from timezone definitions of calendar option.
You can install this to Thunderbird 45.0-52.0 with Lightning 4.7

Comment 13

7 months ago
Paenglab, can you answer the questions from comment 9 from a general perspective?
Flags: needinfo?(richard.marti)
On OS X 62em should be the maximum.
Flags: needinfo?(richard.marti)
(Reporter)

Comment 15

7 months ago
(In reply to Masahiko Imanaka [:marsf] from comment #11)
> (Written in Japanese. This is how to make change and test the customized
> pref window size.)
> 
> NISHI さん
> 
> それでは、言語パック内の数値を変更して試していただけますか?
> 
> 1. まず、次のページから ja-JP-mac.xpi をダウンロードしてください。
>   https://archive.mozilla.org/pub/thunderbird/releases/45.4.0/mac/xpi/
> 2. この xpi ファイルは zip 形式で圧縮されています。適当な場所にアーカイバで展開してください。
> 3. 設定値の書かれたファイルはこれです。
>   /chrome/ja-JP-mac/locale/ja-JP-mac/messenger/preferences/preferences.dtd
> 4. この 54em のところを 66em くらいに書き換えてください。
>   <!ENTITY  prefWindow.styleMac		"width: 54em;">
> 5. xpi ファイルに元の通り zip 形式で再圧縮してください。xpi のファイル名はなんでも結構です。
> 6. テスト用の Thunderbird の新規プロファイルを作成してください。プロファイル作成の手順はこの説明を参照してください。
>   https://support.mozilla.org/kb/using-multiple-profiles
> 7. そのプロファイルで Thunderbird を起動し、アドオンマネージャを開いて、この xpi
> ファイルをドラッグ&ドロップしてインストールしてください。
> 8. Thunderbird を再起動し、設定ウインドウを開いて、その幅が画面内に収まっているか確認してみてください。
> 
> 許容される幅は、できるだけ小さいほうが良いです。
> 画面幅に対して設定ウインドウがどれだけ占めるか、画面全体のスクリーンショットをいただけると助かります。
> よろしくお願いします。
To marsf-san

Sorry, I'm late.
I did what you write.
But,width of the window was not changed if I changed the parameter of "prefWindow.styleMac".

(Japanese)
marsfさん

返信が遅れて、申し訳ありません。
記載された通り"prefWindow.styleMac"の値を変更したのですが、ウインドウ幅が変化しませんでした。

やり方が、間違ってるとは思えないのですが...
(Assignee)

Comment 16

7 months ago
Created attachment 8808597 [details]
Lt4-dialog-fix-patch-0.2.1.xpi

This is a test of the length of timezone items.
Just removed the area name from English part.

Longest items are:

アメリカ/アルゼンチン/ブエノスアイレス (America/Argentina/Buenos Aires)
アメリカ/インディアナ/インディアナポリス (America/Indiana/Indianapolis)
アメリカ/アルゼンチン/リオガジェゴス (America/Argentina/Rio Gallegos)

to

アメリカ/アルゼンチン/ブエノスアイレス (Buenos Aires)
アメリカ/インディアナ/インディアナポリス (Indianapolis)
アメリカ/アルゼンチン/リオガジェゴス (Rio Gallegos)
(Assignee)

Comment 17

7 months ago
(In reply to Richard Marti (:Paenglab) from comment #14)
> On OS X 62em should be the maximum.

Paenglab, thank you for the info. It means that we cannot make wider the option window, and we have to make shorter the length of list items.
Please try my patch add-on 0.2.1.


NISHI さん
テストしていただいてありがとうございます。残念ながら、設定ウィンドウの幅を 62em より大きくすると画面幅に収まらないようです。
上のコメントの Lt4-dialog-fix-patch-0.2.1.xpi をインストールして、オプション画面の幅を確認していただけますか?
(Reporter)

Comment 18

7 months ago
Created attachment 8810033 [details]
Installed0.2.1_General.png
(Reporter)

Comment 19

7 months ago
Created attachment 8810034 [details]
Installed0.2.1_Alarm.png
(Reporter)

Comment 20

7 months ago
Created attachment 8810035 [details]
Installed0.2.1_Category.png
(Reporter)

Comment 21

7 months ago
Created attachment 8810036 [details]
Installed0.2.1_View.png
(In reply to NISHI from comment #18)
> Created attachment 8810033 [details]
> Installed0.2.1_General.png

Please can you open the timezone menulist and scroll to the longest entry and take a screenshot there?
(Reporter)

Comment 23

7 months ago
(In reply to Masahiko Imanaka [:marsf] from comment #17)
> (In reply to Richard Marti (:Paenglab) from comment #14)
> > On OS X 62em should be the maximum.
> 
> Paenglab, thank you for the info. It means that we cannot make wider the
> option window, and we have to make shorter the length of list items.
> Please try my patch add-on 0.2.1.
> 
> 
> NISHI さん
> テストしていただいてありがとうございます。残念ながら、設定ウィンドウの幅を 62em より大きくすると画面幅に収まらないようです。
> 上のコメントの Lt4-dialog-fix-patch-0.2.1.xpi をインストールして、オプション画面の幅を確認していただけますか?

I attached 4 screenshots of Calendar Preference when I have installed Lt4-dialog-fix-patch-0.2.1.xpi.
As you see,though each screenshot is wider than each past one, width is not enough yet. 

(Japanese)
[:marsf]さん

一応インストールしてスクショを取得し添付しました。ご覧の通り、ウインドウ幅が足りていないです。

>Richard
Please wait. I'll back soon!
(Reporter)

Comment 24

7 months ago
Created attachment 8810037 [details]
Installed0.2.1_timezone_dropdown.png
(Reporter)

Comment 25

7 months ago
Created attachment 8810038 [details]
Installed0.2.1_timezone_Buenos_Aires.png
(Reporter)

Comment 26

7 months ago
Created attachment 8810039 [details]
Installed0.2.1_timezone_Indianapolis.png
(Reporter)

Comment 27

7 months ago
Created attachment 8810040 [details]
Installed0.2.1_timezone_Rio_Gallegos.png
(Reporter)

Comment 28

7 months ago
(In reply to Richard Marti (:Paenglab) from comment #22)
> (In reply to NISHI from comment #18)
> > Created attachment 8810033 [details]
> > Installed0.2.1_General.png
> 
> Please can you open the timezone menulist and scroll to the longest entry
> and take a screenshot there?

Paenglab,I've attached 4 screenshots of timezone menulist. Could you confirm them?

On Dropdown list, nothing is longer than [Indianapolis]BTN and [Buenos_Aires]BTN.

If you need any other screenshot, Please order to me
It's looking already better than before. I tried it locally and setting https://dxr.mozilla.org/l10n-mozilla-release/rev/40da02dc415031f4f044260b3e9195b2fddb2230/ja-JP-mac/mail/chrome/messenger/preferences/preferences.dtd#9 to 57em made the window looking good and not cutting anything.
(Assignee)

Comment 30

7 months ago
Created attachment 8810073 [details]
Lt4-dialog-fix-patch-0.2.2.xpi

Addition to 0.2.1:
* Make option dialog wider to 58em on Mac (ja-JP-mac).

54em -> 58em
<!ENTITY  prefWindow.styleMac "width: 58em;">
Attachment #8808597 - Attachment is obsolete: true
(Assignee)

Comment 31

7 months ago
(In reply to NISHI from comment #23)
> I attached 4 screenshots of Calendar Preference when I have installed
> Lt4-dialog-fix-patch-0.2.1.xpi.
> As you see,though each screenshot is wider than each past one, width is not
> enough yet. 

Thank you very much.
The next step, please test with updated patch add-on 0.2.2.

Paenglab:
Thanks!
(Reporter)

Comment 32

7 months ago
Created attachment 8810110 [details]
Installed0.2.2_General.png
(Reporter)

Comment 33

7 months ago
Created attachment 8810111 [details]
Installed0.2.2_Alarm.png
(Reporter)

Comment 34

7 months ago
Created attachment 8810112 [details]
installed0.2.2_Category.png
(Reporter)

Comment 35

7 months ago
Created attachment 8810113 [details]
Installed0.2.2_View.png
(Reporter)

Comment 36

7 months ago
Created attachment 8810114 [details]
Installed0.2.2_timezone.png
(Reporter)

Comment 37

7 months ago
Width is enough.bug is fixed!
(Assignee)

Comment 38

7 months ago
Fixed on aurora and beta.

https://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/d88b617d2f70
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/8f444641a421

https://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/3dbc91a06b6e
https://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/da699c4298c4


Is there a chance to get them for Lightning 4.7 (Thunderbird 45.*) users?

Comment 39

7 months ago
Masahiko, thanks for fixing this. As mentioned in comment 8, Korean locale seems to use the same pattern you did before, so this is likely also an issue for them. Would you mind to get in touch the Korean localization team to point them to this bug so they can port your approach if neccessary?

TB/Lightning only uses ESR for rleases - I'm not aware that there is a way to do string changes on ESR (although that would be great to have). However, the next ESR version moves to Aurora on Monday.
(Assignee)

Comment 40

7 months ago
Hyeonseok:
Hi, Please check if you have same issue on Mac with Korean locale.
To fix this, you can re-use my patch add-on (Lt4-dialog-fix-patch-0.2.2.xpi at comment 30) to adjust the width of option window and list items.
(Assignee)

Updated

7 months ago
Assignee: nobody → chimantaea_mirabilis
OS: Unspecified → Mac OS X
(Assignee)

Updated

7 months ago
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED

Comment 41

4 months ago
Confirmed that Korean has the same issue. We decided to remove all redundant English text. Thank you for inform this.
You need to log in before you can comment on or make changes to this bug.