Closed Bug 1306898 Opened 8 years ago Closed 8 years ago

DOM panel is blank on lots of websites

Categories

(DevTools :: DOM, defect, P1)

52 Branch
defect

Tracking

(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 verified)

VERIFIED FIXED
Firefox 52
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- verified

People

(Reporter: ntim, Assigned: Honza)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

STR:
- Go to http://google.com (happens on some other websites as well)
- Open devtools
- Enable DOM Panel (if not enabled)
- Click DOM Panel tab

AR:
- Blank DOM panel

ER:
- DOM Panel should be populated

Notes:
It seems to work on some websites, eg. Github, Yahoo, ...

Browser console seems to display a React related error.
Flags: needinfo?(odvarko)
Also reproducible on https://bugzilla.mozilla.org
Regression caused by bug 1303126

Honza
Assignee: nobody → odvarko
Flags: needinfo?(odvarko)
Priority: -- → P1
Attached patch bug1306898.patchSplinter Review
Avoid exception

Honza
Attachment #8797130 - Flags: review?(ntim.bugs)
Comment on attachment 8797130 [details] [diff] [review]
bug1306898.patch

Review of attachment 8797130 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the prompt fix, works for me locally!

It would be nice to have bug 1264002 fixed or at least a basic test that verifies that the DOM panel has fully rendered.
Attachment #8797130 - Flags: review?(ntim.bugs) → review+
Last good revision: 62f79d676e0e11b3ad59a5425b3ebb3ec5bbefb5
First bad revision: e2d2897e4a7449759267bf168e6b37f7b8c3a94b

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=62f79d676e0e11b3ad59a5425b3ebb3ec5bbefb5&tochange=e2d2897e4a7449759267bf168e6b37f7b8c3a94b
Version: unspecified → 52 Branch
(In reply to Tim Nguyen :ntim (use needinfo?) from comment #4)
> Comment on attachment 8797130 [details] [diff] [review]
> bug1306898.patch
> 
> Review of attachment 8797130 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for the prompt fix, works for me locally!
> 
> It would be nice to have bug 1264002 fixed or at least a basic test that
> verifies that the DOM panel has fully rendered.
Yes, totally agree. I'll do it.

Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/366c5e0d028d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
I  have reproduced this bug with Nightly 52.0a1 (2016-10-01) (64-bit) on WIndows 7, 64 bit 


This bug's fix is verified with latest Nightly

build id : 20161020030211

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

 [bugday-20161019]
Status: RESOLVED → VERIFIED
I have reproduced this bug with nightly 52.0a1 (2016-10-1) on ubuntu ,64 bit.
 
This bug's fix is verified with latest Nightly.

Build Id : 20161010230054

User Agent :Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0.

[Bugday-20161019]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: