Closed Bug 1306962 Opened 8 years ago Closed 11 months ago

Intermittent devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox52 wontfix)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox52 --- wontfix

People

(Reporter: aryx, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown]) 

https://treeherder.mozilla.org/logviewer.html#?job_id=36883386&repo=mozilla-inbound

01:14:14     INFO -  63 INFO Click in the already opened editor input
01:14:14     INFO -  64 INFO TEST-PASS | devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | Inplace editor input should still have focus. -
01:14:14     INFO -  65 INFO Check the input can still be used as expected
01:14:14     INFO -  66 INFO TEST-PASS | devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | Should have the right value in the editor. -
01:14:14     INFO -  67 INFO TEST-PASS | devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | Should have updated the margin. -
01:14:14     INFO -  68 INFO TEST-PASS | devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | Should be the right margin-top on the element. -
01:14:14     INFO -  69 INFO TEST-PASS | devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | Should have the right value in the box model. -
01:14:14     INFO -  70 INFO Leaving test bound
01:14:14     INFO -  71 INFO Removing tab.
01:14:14     INFO -  72 INFO Waiting for event: 'TabClose' on [object XULElement].
01:14:14     INFO -  73 INFO Got event: 'TabClose' on [object XULElement].
01:14:14     INFO -  74 INFO Tab removed and finished closing
01:14:14     INFO -  75 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P3
patrick, we see in aurora (52) more timeouts in devtools - most pronounced on Linux debug devtools. Do you know whats going on there ?
Flags: needinfo?(pbrosset)
(In reply to Carsten Book [:Tomcat] from comment #3)
> patrick, we see in aurora (52) more timeouts in devtools - most pronounced
> on Linux debug devtools. Do you know whats going on there ?
I don't know what would cause the test to run slower on aurora to be honest. I've noticed that very recently, a bunch of our (already long) tests started to go over the 45s timeout threshold on linux debug test environments. It's hard to know if this is due to the environment being slower or some part of Firefox or devtools suffering from a perf problem (which Talos would have reported).
The test passes, but it just a little bit too long.
I don't think we get a lot of value for this test passing on linux debug on aurora. So if this continues to fail as frequently as this, I advise disabling this one on linux debug aurora.
Flags: needinfo?(pbrosset)
Assignee: nobody → gbrown
Depends on: 1323625
There have been no failures since bug 1323625 was resolved - that reduced the duration of this test by a few seconds, on linux/debug.

This test remains a long-running test on linux/debug, so I wouldn't be surprised if failures return one day, but I don't think intervention is required at this time. I'll leave the bug open, but take no action.

Test durations for devtools/client/inspector/components/test/browser_boxmodel_editablemodel.js on mozilla-central,mozilla-inbound,autoland between Dec 22 and Dec 29:
linux32/debug:                  39.14 s (33.20 s - 42.29 s over 19 runs)
linux32/opt:                     9.75 s (9.18 s - 11.15 s over 23 runs)
linux32/opt-e10s:               10.10 s (8.86 s - 11.94 s over 24 runs)
linux32/pgo:                     8.84 s (8.27 s - 9.46 s over 10 runs)
linux32/pgo-e10s:                8.50 s (8.01 s - 8.94 s over 16 runs)
linux64/asan-chunked:           24.87 s (19.21 s - 31.27 s over 79 runs)
linux64/asan-e10s:              25.58 s (19.21 s - 28.63 s over 39 runs)
linux64/debug-chunked:          16.35 s (15.81 s - 17.26 s over 33 runs)
linux64/opt:                     9.94 s (8.79 s - 12.45 s over 30 runs)
linux64/opt-chunked:             5.68 s (5.40 s - 6.03 s over 25 runs)
linux64/opt-e10s:                8.09 s (5.43 s - 10.72 s over 31 runs)
linux64/pgo:                     7.98 s (6.58 s - 9.30 s over 11 runs)
linux64/pgo-chunked:             4.91 s (4.58 s - 5.27 s over 18 runs)
linux64/pgo-e10s:                7.17 s (4.73 s - 10.83 s over 18 runs)
macosx64/debug:                 13.10 s (12.14 s - 15.63 s over 22 runs)
macosx64/debug-e10s:            12.36 s (11.76 s - 12.87 s over 22 runs)
macosx64/opt:                    5.03 s (4.41 s - 5.77 s over 28 runs)
macosx64/opt-e10s:               4.80 s (4.38 s - 5.25 s over 34 runs)
win32/debug:                    21.92 s (21.23 s - 23.69 s over 19 runs)
win32/debug-e10s:               18.48 s (17.17 s - 20.35 s over 23 runs)
win32/opt:                       5.67 s (5.25 s - 6.43 s over 23 runs)
win32/opt-e10s:                  5.25 s (5.01 s - 5.64 s over 24 runs)
win32/pgo:                       4.51 s (4.18 s - 4.77 s over 15 runs)
win32/pgo-e10s:                  4.45 s (4.00 s - 4.67 s over 26 runs)
win64/debug:                    21.29 s (20.12 s - 23.03 s over 24 runs)
win64/debug-e10s:               18.42 s (16.56 s - 25.96 s over 26 runs)
win64/opt:                       5.41 s (4.92 s - 5.74 s over 30 runs)
win64/opt-e10s:                  4.98 s (4.42 s - 5.30 s over 30 runs)
win64/pgo:                       4.49 s (4.15 s - 4.97 s over 19 runs)
win64/pgo-e10s:                  4.28 s (4.25 s - 4.31 s over 22 runs)
Assignee: gbrown → nobody
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
here is a case of jsdcov having a failure, probably a perma fail.

:gmierz, can you add this to your queue?  Possibly this is something for a UCOSP student to pick up if they have interests in making things stable :)
Flags: needinfo?(gmierz2)
Sure thing! We have another error with this test on jsdcov as well (which will need to be fixed before this one): https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=jsdcov&selectedJob=127401668
I assume we fixed this in other bugs.
Flags: needinfo?(gmierz2)
Whiteboard: [stockwell unknown]
Product: Firefox → DevTools
Severity: normal → S3

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.