130701 - NULL Pointer in Trunk [@ nsMenuBarFrame::SetCurrentMenuItem]

Status: VERIFIED DUPLICATE of bug 133183

(Core :: XUL, defect, P3)

Description

[David Bradley]

Build: CVS pull, from 3/13/02, release build with symbols.

The call to menubar->SetActiveMenu(newActive) Line 571 crashes because menubar
is null. menubar was retrieved from the mContent member via a QI. So either the
QI failed and returned null, or the mContent member was null. mContent doesn't
appear to come from nsMenuBarFrame, and I wasn't able to track down where it
appears in the inheritance chain.

Stack trace coming

Comment 1

[David Bradley]

Attachment: Stack from crash

Comment 2

[David Bradley]

This occured during starting up the browser and doesn't appear to be repeatable.
It occured after I terminated the Mozilla process from another run.

Comment 3

[David Bradley]

Sorry this must have been a flaky build thing. I clobbered and repulled and it
went away.

I'm not going to mark this invalid myself. Mainly because I don't know if
defensive code might be in order here anyway (Could mContent be invalid, or
could the QI fail). If the owner feels it's overkill then just mark this invalid
and close it.

Comment 4

[Chris Petersen]

Changing Priority to P3.

Comment 5

[Kevin McCluskey (gone)]

Not layout. Setting component and reassigning.

Comment 6

[Jay Patel [:jay]]

Some other poor guy crashed here a lot recently:

nsMenuBarFrame::SetCurrentMenuItem   19 
BBID range: 4110107 - 4332428
Min/Max Seconds since last crash: 20 - 157056
Min/Max Runtime: 59 - 159430
Crash data range: 2002-03-16 to 2002-03-21
Build ID range: 2002031510 to 2002031910
Keyword List : 
Stack Trace: 

	 nsMenuBarFrame::SetCurrentMenuItem
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuBarFrame.cpp  line 574]
	 nsMenuFrame::HandleEvent
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp  line 529]
	 PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6073]
	 PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 5979]
	 nsViewManager::HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp  line 2043]
	 nsView::HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line 306]
	 nsViewManager::DispatchEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp  line 1863]
	 HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line 83]
	 nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 869]
	 nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 886]
	 nsWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 4713]
	 ChildWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 4963]
	 nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 3630]
	 nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 1131]
	 USER32.dll + 0x3a5f (0x77d43a5f)
	 USER32.dll + 0x3b2e (0x77d43b2e)
	 USER32.dll + 0x3d6a (0x77d43d6a)
	 USER32.dll + 0x41fd (0x77d441fd)
	 nsAppShellService::Run
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp  line 309]
	 main1
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1366]
	 main
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1701]
	 WinMain
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1719]
	 WinMainCRTStartup()
	 kernel32.dll + 0x1eb69 (0x77e7eb69)
 
 	Source File :
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/xul/base/src/nsMenuBarFrame.cpp
line : 574
     (4120928)	URL: ftp://ftp.fim-ag.de
     (4116458)	URL: ftp://ftp.fim-ag.de
     (4115947)	URL: ftp://ftp.fim-ag.de
     (4115783)	URL: ftp://ftp.fim-ag.de
     (4113650)	URL: ftp://ftp.fim-ag.de
     (4113570)	URL: ftp://ftp.fim-ag.de
     (4113436)	URL: ftp://ftp.fim-ag.de
     (4110677)	URL: ftp://ftp.fim-ag.de
     (4110425)	URL: ftp://ftp.fim-ag.de
     (4110164)	URL: ftp://ftp.fim-ag.de
     (4110107)	URL: ftp://ftp.fim-ag.de

Adding crash, topcrash and qawanted to see if we can reproduce this again. 
According to Talkback, this last occurred with MozillaTrunk builds from 3/19. 
Either the user above stopped trying to crash or no one has seen this crash
since then.  Still...it wouldn't hurt to put in a null check if that would stop
any similar crashes from coming back.

Comment 7

[John Morrison]

*** This bug has been marked as a duplicate of 133183 ***

Comment 8

[shrirang khanzode]

mass duplicate verifications . For filtering purposes, pls use keywd
"massdupverification"