1307016 - Tests should output ascii for compatibility with terminals

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

During refactoring of the tests I've changed the logging and removed some of the forced conversions to ascii. However, it appears that the jenkins test machines do not all play nice with this. Thus, for now I think it appropriate that the tests again convert all output that may contain non-ascii characters to ascii.

I think there is merit in a more robust approach where we use the widest character set available to us. However, I'd think it better to address that in a follow up. My thinking for this is we currently have the tests running on at least 3 separate platforms (custom Jenkins nodes, Build bot, Task cluster), and I'd rather wait until we've reached a more standardised setting before making those changes.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1307016 - Have puppeteer __str__ encode fields to ascii.

At least some of the environments the tests are running in do not appear to play
nice with non-ascii characters. Some of the jenkins runs are currently unhappy
due to this. This patch sees that all fields are encoded as ascii with
non-compatible characters replaced.

Review commit: https://reviewboard.mozilla.org/r/83426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83426/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8797816 [details]
Bug 1307016 - Have puppeteer __str__ encode fields to ascii.

https://reviewboard.mozilla.org/r/83426/#review82324

Note: there's a typo in the commit message -- ascii.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8797816 [details]
Bug 1307016 - Have puppeteer __str__ encode fields to ascii.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83426/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0817cce76da
Have puppeteer __str__ encode fields to ascii. r=maja_zf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0817cce76da

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bryce, do we need to backout the patch as landed or why did you reopen the bug? If follow-up work is needed it should be done on a follow-up bug. This one should be kept as fixed.

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Ah, okay, my bad. The work can be done in a follow up then. I was unfamiliar with the convention.