1307055 - Move some pref settings from dom/media/test/manifest.js to testing/profiles/prefs_general.js

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

We want these prefs to take effect as early as possible before running any test code. Otherwise, it might not work as expected.

See: http://searchfox.org/mozilla-central/rev/d1276b5b84e6cf7991c8e640b5e0ffffd54575a6/dom/media/test/manifest.js#17

It is easy to make a mistake by calling |document.createElement('video')| before changing the pref. Moving the prefs to prefs_general.js will prevent this problem.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307055. Part 1 - add some prefs to prefs_general.js for mochitests so they can take effect as soon as possible before running any test code.

Review commit: https://reviewboard.mozilla.org/r/83470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83470/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307055. Part 2 - remove unnecessary pref settings and unused functions.

Review commit: https://reviewboard.mozilla.org/r/83472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83472/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8797859 [details]
Bug 1307055. Part 1 - add some prefs to prefs_general.js for mochitests so they can take effect as soon as possible before running any test code.

https://reviewboard.mozilla.org/r/83470/#review82138

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8797860 [details]
Bug 1307055. Part 2 - remove unnecessary pref settings and unused functions.

https://reviewboard.mozilla.org/r/83472/#review82140

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/238809d53b30
Part 1 - add some prefs to prefs_general.js for mochitests so they can take effect as soon as possible before running any test code. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/ea7d72872079
Part 2 - remove unnecessary pref settings and unused functions. r=cpearce

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/238809d53b30
https://hg.mozilla.org/mozilla-central/rev/ea7d72872079