Closed Bug 1307055 Opened 4 years ago Closed 4 years ago

Move some pref settings from dom/media/test/manifest.js to testing/profiles/prefs_general.js

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

We want these prefs to take effect as early as possible before running any test code. Otherwise, it might not work as expected.

See: http://searchfox.org/mozilla-central/rev/d1276b5b84e6cf7991c8e640b5e0ffffd54575a6/dom/media/test/manifest.js#17

It is easy to make a mistake by calling |document.createElement('video')| before changing the pref. Moving the prefs to prefs_general.js will prevent this problem.
Assignee: nobody → jwwang
Priority: -- → P3
Attachment #8797859 - Flags: review?(cpearce)
Attachment #8797860 - Flags: review?(cpearce)
Comment on attachment 8797859 [details]
Bug 1307055. Part 1 - add some prefs to prefs_general.js for mochitests so they can take effect as soon as possible before running any test code.

https://reviewboard.mozilla.org/r/83470/#review82138
Attachment #8797859 - Flags: review?(cpearce) → review+
Comment on attachment 8797860 [details]
Bug 1307055. Part 2 - remove unnecessary pref settings and unused functions.

https://reviewboard.mozilla.org/r/83472/#review82140
Attachment #8797860 - Flags: review?(cpearce) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/238809d53b30
Part 1 - add some prefs to prefs_general.js for mochitests so they can take effect as soon as possible before running any test code. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/ea7d72872079
Part 2 - remove unnecessary pref settings and unused functions. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/238809d53b30
https://hg.mozilla.org/mozilla-central/rev/ea7d72872079
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.