Closed Bug 1307063 Opened 8 years ago Closed 8 years ago

Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

DecodingFirstFrameState is the only caller.
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Attachment #8797375 - Flags: review?(kikuo)
Comment on attachment 8797375 [details]
Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/82974/#review81716

r+ with the following addressed.

::: dom/media/MediaDecoderStateMachine.cpp:449
(Diff revision 1)
> -    mMaster->MaybeFinishDecodeFirstFrame();
> +    MaybeFinishDecodeFirstFrame();
>      return true;
>    }
> +
> +private:
> +  // Notify FirstFrameLoaded if having decoded first frames and

"frames" => "frame"
Attachment #8797375 - Flags: review?(kikuo) → review+
Comment on attachment 8797375 [details]
Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/82974/#review81716

> "frames" => "frame"

The plural form is used deliberately for we have first frames from the audio and video tracks respectively.
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86597cc0234a
Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState. r=kikuo
https://hg.mozilla.org/mozilla-central/rev/86597cc0234a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: