1307063 - Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

DecodingFirstFrameState is the only caller.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

Review commit: https://reviewboard.mozilla.org/r/82974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82974/

Comment 2

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8797375 [details]
Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/82974/#review81716

r+ with the following addressed.

::: dom/media/MediaDecoderStateMachine.cpp:449
(Diff revision 1)
> -    mMaster->MaybeFinishDecodeFirstFrame();
> +    MaybeFinishDecodeFirstFrame();
>      return true;
>    }
> +
> +private:
> +  // Notify FirstFrameLoaded if having decoded first frames and

"frames" => "frame"

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8797375 [details]
Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/82974/#review81716

> "frames" => "frame"

The plural form is used deliberately for we have first frames from the audio and video tracks respectively.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86597cc0234a
Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState. r=kikuo

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86597cc0234a