Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState

RESOLVED FIXED in Firefox 52

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
DecodingFirstFrameState is the only caller.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8797375 - Flags: review?(kikuo)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8797375 [details]
Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/82974/#review81716

r+ with the following addressed.

::: dom/media/MediaDecoderStateMachine.cpp:449
(Diff revision 1)
> -    mMaster->MaybeFinishDecodeFirstFrame();
> +    MaybeFinishDecodeFirstFrame();
>      return true;
>    }
> +
> +private:
> +  // Notify FirstFrameLoaded if having decoded first frames and

"frames" => "frame"
Attachment #8797375 - Flags: review?(kikuo) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8797375 [details]
Bug 1307063. Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState.

https://reviewboard.mozilla.org/r/82974/#review81716

> "frames" => "frame"

The plural form is used deliberately for we have first frames from the audio and video tracks respectively.
(Assignee)

Comment 4

2 years ago
Thanks!

Comment 5

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86597cc0234a
Move MDSM::MaybeFinishDecodeFirstFrame() into DecodingFirstFrameState. r=kikuo

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86597cc0234a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.