Closed
Bug 1307127
Opened 8 years ago
Closed 8 years ago
Intermittent test_navigation.py TestNavigate.test_error_when_exceeding_page_load_timeout | AssertionError: TimeoutException not raised
Categories
(Testing :: Marionette Client and Harness, defect)
Tracking
(firefox50 fixed, firefox51 fixed, firefox52 fixed)
RESOLVED
FIXED
mozilla52
People
(Reporter: intermittent-bug-filer, Assigned: ato)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=36912113&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/KIoiChRISeyPWDMqPvY1uQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log
Comment 2•8 years ago
|
||
I would assume its a new failure related to the code changes from bug 1302707? Andreas, what do you think?
Flags: needinfo?(ato)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #2) > I would assume its a new failure related to the code changes from bug > 1302707? Andreas, what do you think? Possibly. It’s interesting because line :129 should never really be hit: https://github.com/mozilla/gecko-dev/blob/master/testing/marionette/harness/marionette/tests/unit/test_navigation.py#L129 This means that self.marionette.navigate(self.marionette.absolute_url("slow")) sometimes manages to complete, although it should always throw an exception because self.marionette.set_page_load_timeout(0) is being set on the previous line.
Flags: needinfo?(ato)
Assignee | ||
Comment 5•8 years ago
|
||
I think I have found the likely culprit. driver.js:977 is calling Marionette:pollForReadyState from chrome without passing along all the parameters of the original msg.json structure: https://github.com/mozilla/gecko-dev/blob/master/testing/marionette/driver.js#L977 This means the pageTimeout gets lost.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (Intermittent Failures Robot) |
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8800376 [details] Bug 1307127 - Pass along pageTimeout when polling for ready state from chrome; https://reviewboard.mozilla.org/r/85284/#review85678
Attachment #8800376 -
Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2069ba1153a5 Pass along pageTimeout when polling for ready state from chrome; r=automatedtester
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2069ba1153a5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee | ||
Comment 11•8 years ago
|
||
Sheriffs: This is a test-only fix.
Whiteboard: [checkin-needed-aurora] [checkin-needed-beta]
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/a5ac50925a92
status-firefox51:
--- → fixed
Updated•8 years ago
|
Whiteboard: [checkin-needed-aurora] [checkin-needed-beta] → [checkin-needed-beta]
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/274a1f17a29a
status-firefox50:
--- → fixed
Updated•8 years ago
|
Whiteboard: [checkin-needed-beta]
Comment hidden (Intermittent Failures Robot) |
Comment 15•7 years ago
|
||
Is this fix added to the latest version geckodriver v0.13.0?
Flags: needinfo?(ato)
Comment 16•7 years ago
|
||
The fix on this bug is unrelated to geckodriver, but has been fixed for Firefox 50 and upwards.
Flags: needinfo?(ato)
Comment 17•7 years ago
|
||
I use Firefox 50.1.0, but my selenium automation script is still not waiting for Implicit load. I read in https://github.com/mozilla/geckodriver/issues/96 that the Implicit load issue is partly addressed in this ticket. Can you please confirm if that's the case? Is there any other ticket that needs to be fixed before the Implicit wait works in Marionette driver? Please advise.
Flags: needinfo?(hskupin)
Flags: needinfo?(ato)
Comment 18•7 years ago
|
||
As you can see https://github.com/mozilla/geckodriver/issues/96 is still open, and as Andreas mentioned this bug addresses it in parts. There are still remaining issues open for Marionette (eg. reload), but also the general discussion about implicit reloads doesn't seem to have finished. At least that is what I get from the github issue. So all your questions are closer related to this issue as this bug.
Flags: needinfo?(hskupin)
Updated•7 years ago
|
Flags: needinfo?(ato)
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 19•1 year ago
|
||
Moving bug to Testing::Marionette Client and Harness component per bug 1815831.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•