Closed Bug 1307141 Opened 5 years ago Closed 5 years ago

Submit setLineDash tests to wpt

Categories

(Core :: Canvas: 2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(2 files)

No description provided.
This test was originally written by David Caldwell in changeset d18ebc644b89
(bug 1006656). He has relicensed his contribution under the CC0 at
<https://bugzilla.mozilla.org/show_bug.cgi?id=1073556#c66>.
Attachment #8797178 - Flags: review?(james)
This test was originally written by Rik Cabanier in changeset b16182c733bb
(bug 768067). He has relicensed his contribution under the CC0 at
<https://bugzilla.mozilla.org/show_bug.cgi?id=1073556#c67>.
Attachment #8797179 - Flags: review?(james)
Comment on attachment 8797178 [details] [diff] [review]
Submit test_setlinedash.html to WPT

Review of attachment 8797178 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/2dcontext/line-styles/setLineDash.html
@@ +1,3 @@
> +<!DOCTYPE html>
> +<meta charset=utf-8>
> +<!--

Not sure if this should be in wpt submissions. I think technically we are taking them out of the public domain and relicensing them.
Attachment #8797178 - Flags: review?(james) → review+
Comment on attachment 8797179 [details] [diff] [review]
Submit test_linedash from test_canvas.html to WPT

Review of attachment 8797179 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/2dcontext/line-styles/setLineDash.html
@@ +92,5 @@
> +  _assertPixel(canvas, 105, 40, 0, 255, 0, 255, 0);
> +  _assertPixel(canvas, 90, 35, 0, 0, 0, 0, 0);
> +  _assertPixel(canvas, 90, 25, 0, 255, 0, 255, 0);
> +
> +  // Ensure that all zeros or negative pattern does not cause error state in context, see bug 1169609

Remove bug.
Attachment #8797179 - Flags: review?(james) → review+
Pushed by Ms2ger@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a6fa9b51784
Submit test_setlinedash.html to WPT; r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/a580d0d432be
Submit test_linedash from test_canvas.html to WPT; r=jgraham
https://hg.mozilla.org/mozilla-central/rev/0a6fa9b51784
https://hg.mozilla.org/mozilla-central/rev/a580d0d432be
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.