Closed Bug 1307216 Opened 3 years ago Closed 3 years ago

4,100 instances of "'NS_FAILED(rv)'" emitted from dom/plugins/base/nsPluginHost.cpp during windows8-64 debug testing

Categories

(Core :: Plug-ins, defect, P5)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 4111 WARNING: 'NS_FAILED(rv)', file dom/plugins/base/nsPluginHost.cpp, line 2364

This warning [1] shows up in the following test suites:

>   1142 - Mochitest Other oth
>    916 - Mochitest 1
>    232 - Mochitest Browser Chrome bc6
>    196 - Mochitest 5
>    178 - Mochitest 3
>    168 - Crashtest C
>    158 - Mochitest Browser Chrome bc3
>    155 - Mochitest Clipboard cl
>    152 - Mochitest Browser Chrome bc4
>    108 - Mochitest 4
>    104 - Mochitest 2
>     64 - Mochitest Browser Chrome bc5
>     62 - Mochitest Browser Chrome bc2
>     56 - Mochitest Browser Chrome bc1
>     38 - Reftest Unaccelerated Ru
>     38 - Reftest R
>     36 - Mochitest DevTools Browser Chrome dt6
>     36 - Mochitest Media mda
>     32 - Mochitest DevTools Browser Chrome dt1
>     30 - Mochitest DevTools Browser Chrome dt4
>     28 - Mochitest GPU gpu
>     24 - Mochitest DevTools Browser Chrome dt5
>     22 - Mochitest Browser Chrome bc7
>     20 - Mochitest DevTools Browser Chrome dt2
>     16 - Mochitest WebGL gl3
>     16 - Mochitest DevTools Browser Chrome dt3
>     16 - Mochitest DevTools Browser Chrome dt8
>     12 - Mochitest DevTools Browser Chrome dt7
>      8 - Mochitest Jetpack JP
>      8 - Mochitest WebGL gl1
>      6 - JSReftest J
>      6 - W3C Web Platform Tests 5
>      4 - Mochitest WebGL gl2
>      4 - W3C Web Platform Reftests Wr
>      4 - W3C Web Platform Tests 6
>      2 - W3C Web Platform Tests 10
>      2 - W3C Web Platform Tests 9
>      2 - W3C Web Platform Tests 8
>      2 - W3C Web Platform Tests 7
>      2 - W3C Web Platform Tests 4
>      2 - W3C Web Platform Tests 3
>      2 - W3C Web Platform Tests 2
>      2 - W3C Web Platform Tests 1

It shows up in 157 tests. A few of the most prevalent:

>   1576 -        Shutdown
>    736 -        dom/base/test/chrome/test_bug391728.html
>    528 -        dom/base/test/test_bug368972.html
>    176 -        dom/base/test/test_bug704320.html
>     96 -        file:///C:/slave/test/build/tests/reftest/tests/dom/plugins/test/crashtests/41276-1.html
>     80 -        uriloader/exthandler/tests/mochitest/test_unsafeBidiChars.xhtml
>     56 -        dom/base/test/test_bug425013.html
>     52 -        toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js
>     42 -        toolkit/mozapps/extensions/test/browser/browser_bug562797.js
>     36 -        dom/tests/mochitest/general/test_resource_timing_cross_origin.html

[1] https://hg.mozilla.org/mozilla-central/annotate/955840bfd3c2/dom/plugins/base/nsPluginHost.cpp#l2364
This code was introduced in bug 1307216, I'm not sure when the warnings started showing up.
Blocks: 1131136
OS: All → Windows
The key doesn't exist because the test slaves don't have any plugins installed, so we can't open/watch it. I think we should just remove the NS_WARN_IF here.
Priority: -- → P5
Comment on attachment 8797690 [details]
Bug 1307216 - Remove warning about non-existent plug-in registry key.

https://reviewboard.mozilla.org/r/83328/#review83012
Attachment #8797690 - Flags: review?(benjamin) → review+
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8c12e07420d
Remove warning about non-existent plug-in registry key. r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/b8c12e07420d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.