3,700 instances of "Using default font" emitted from gfx/thebes/gfxDWriteFonts.cpp during windows8-64 debug testing

RESOLVED FIXED in Firefox 52

Status

()

Core
Graphics
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: erahm, Assigned: mchang)

Tracking

(Blocks: 1 bug)

Trunk
mozilla52
All
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

> 3661 WARNING: Using default font: file gfx/thebes/gfxDWriteFonts.cpp, line 113

This warning [1] shows up in the following test suites:

>   1736 - Reftest Unaccelerated Ru
>   1709 - Reftest R
>    160 - Mochitest 5
>     26 - Mochitest Other oth
>      8 - Mochitest DevTools Browser Chrome dt8
>      7 - Mochitest Browser Chrome bc6
>      6 - Crashtest C
>      6 - W3C Web Platform Tests 1
>      2 - Mochitest 1
>      1 - Mochitest 3

It shows up in 796 tests. A few of the most prevalent:

>    257 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/text-svgglyphs/svg-glyph-extents.html == file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/text-svgglyphs/svg-glyph-extents-ref.html
>    112 -        layout/style/test/test_unicode_range_loading.html
>    108 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/stretchmapping-137.html == http://localhost:49336/1475476627028/414/font-matching/stretchmapping-137-ref.html
>    108 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/stretchmapping-137.html == http://localhost:49299/1475476721457/414/font-matching/stretchmapping-137-ref.html
>     99 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/stretchmapping-35.html == http://localhost:49299/1475476721454/413/font-matching/stretchmapping-35-ref.html
>     99 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/stretchmapping-35.html == http://localhost:49336/1475476627025/413/font-matching/stretchmapping-35-ref.html
>     90 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/stretchmapping-all.html == http://localhost:49299/1475476721449/411/font-matching/stretchmapping-all-ref.html
>     90 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/stretchmapping-all.html == http://localhost:49336/1475476627021/411/font-matching/stretchmapping-all-ref.html
>     62 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/font-stretch-1.html == http://localhost:49336/1475476627030/415/font-matching/font-stretch-1-ref.html
>     62 -        file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-matching/font-shorthand-stretch-1.html == http://localhost:49299/1475476721462/416/font-matching/font-stretch-1-ref.html

[1] https://hg.mozilla.org/mozilla-central/annotate/955840bfd3c2/gfx/thebes/gfxDWriteFonts.cpp#l113
This warning was introduced in bug 842894, I'm not sure how long it has been triggering.
Blocks: 842894
OS: All → Windows

Updated

2 years ago
Priority: -- → P3
Whiteboard: [gfx-noted]
(Assignee)

Comment 2

2 years ago
(In reply to Eric Rahm [:erahm] from comment #1)
> This warning was introduced in bug 842894, I'm not sure how long it has been
> triggering.

Probably about a week since that's when skia landed. I'm surprised it's happening that much.
Assignee: nobody → mchang
(Assignee)

Comment 3

2 years ago
BTW, does this only happen on Windows 8?
Flags: needinfo?(erahm)
(In reply to Mason Chang [:mchang] from comment #3)
> BTW, does this only happen on Windows 8?

I only see it on Windows 8 (which is also 64-bit). XP (32-bit) and Windows 7 VM (32-bit) don't emit the warning.
Flags: needinfo?(erahm)
OS: Windows → Windows 8
(In reply to Mason Chang [:mchang] from comment #2)
> (In reply to Eric Rahm [:erahm] from comment #1)
> > This warning was introduced in bug 842894, I'm not sure how long it has been
> > triggering.
> 
> Probably about a week since that's when skia landed. I'm surprised it's
> happening that much.

Looks like it's been around since at least July (I can't bisect further back).
(Assignee)

Comment 6

2 years ago
Created attachment 8800026 [details] [diff] [review]
Replace warning with an assert
Attachment #8800026 - Flags: review?(lsalzman)
Attachment #8800026 - Flags: review?(lsalzman) → review+

Comment 7

2 years ago
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2af033c15b03
Assert font file exists if using default font with skia. r=lsalzman

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2af033c15b03
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.