Open Bug 1307237 Opened 3 years ago Updated 2 years ago

11,600 instances of "'!IsSelectionValid()'" and associated warnings emitted from widget/ContentCache.cpp during debug testing

Categories

(Core :: Widget, defect)

All
macOS
defect
Not set

Tracking

()

People

(Reporter: erahm, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: tpi:-)

> 5835 WARNING: '!IsSelectionValid()', file widget/ContentCache.cpp, line 651

This warning [1] shows up in the following test suites:

>   2724 - Mochitest e10s 2
>   1398 - Mochitest e10s 5
>   1296 - Mochitest e10s 4
>    162 - Mochitest e10s DevTools Browser Chrome dt4
>    126 - Mochitest e10s 3
>     66 - Mochitest e10s Browser Chrome bc7
>     36 - Mochitest e10s Browser Chrome bc4
>     27 - Mochitest e10s 1

It shows up in 35 tests. A few of the most prevalent:

>   1800 - [e10s] dom/html/test/forms/test_input_range_rounding.html
>   1080 - [e10s] layout/base/tests/test_scroll_snapping.html
>    960 - [e10s] layout/forms/test/test_bug935876.html
>    576 - [e10s] dom/html/test/forms/test_input_range_key_events.html
>    171 - [e10s] layout/base/tests/test_reftests_with_caret.html
>    126 - [e10s] dom/html/test/forms/test_input_radio_radiogroup.html
>    126 - [e10s] dom/tests/mochitest/bugs/test_bug265203.html
>    120 - [e10s] layout/forms/test/test_bug563642.html
>    120 - [e10s] layout/forms/test/test_bug365410.html
>    108 - [e10s] devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-events.js

[1] https://hg.mozilla.org/mozilla-central/annotate/955840bfd3c2/widget/ContentCache.cpp#l651
This correlates 1:1 with a IPC warning as well and appears to be e10s only. First we see "WARNING: '!aEvent.mSucceeded'" and then "WARNING: '!IsSelectionValid()'".

Masayuki I think this is generally related to code you're interested in.

> 5835 WARNING: '!aEvent.mSucceeded', file dom/ipc/TabParent.cpp, line 2246

This warning [1] shows up in the following test suites:

>   2724 - Mochitest e10s 2
>   1398 - Mochitest e10s 5
>   1296 - Mochitest e10s 4
>    162 - Mochitest e10s DevTools Browser Chrome dt4
>    126 - Mochitest e10s 3
>     66 - Mochitest e10s Browser Chrome bc7
>     36 - Mochitest e10s Browser Chrome bc4
>     27 - Mochitest e10s 1

It shows up in 35 tests. A few of the most prevalent:

>   1800 - [e10s] dom/html/test/forms/test_input_range_rounding.html
>   1080 - [e10s] layout/base/tests/test_scroll_snapping.html
>    960 - [e10s] layout/forms/test/test_bug935876.html
>    576 - [e10s] dom/html/test/forms/test_input_range_key_events.html
>    171 - [e10s] layout/base/tests/test_reftests_with_caret.html
>    126 - [e10s] dom/html/test/forms/test_input_radio_radiogroup.html
>    126 - [e10s] dom/tests/mochitest/bugs/test_bug265203.html
>    120 - [e10s] layout/forms/test/test_bug563642.html
>    120 - [e10s] layout/forms/test/test_bug365410.html
>    108 - [e10s] devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-events.js

[1] https://hg.mozilla.org/mozilla-central/annotate/955840bfd3c2/dom/ipc/TabParent.cpp#l2246
Flags: needinfo?(masayuki)
OS: All → Mac OS X
Summary: 5,800 instances of "'!IsSelectionValid()'" emitted from widget/ContentCache.cpp during osx-10-10 debug testing → 11,600 instances of "'!IsSelectionValid()'" and associated warnings emitted from widget/ContentCache.cpp during osx-10-10 debug testing
Probably, a bug of TextInputHandler (or its related classes) is detected.

I guess that before preparing selection cache, TextInputHandler receives some notifications which causes to query the contents.
Flags: needinfo?(masayuki)
Whiteboard: tpi:-
I see this warning while running browser/base/content/test/performance/browser_windowopen_reflows.js on Linux.
Summary: 11,600 instances of "'!IsSelectionValid()'" and associated warnings emitted from widget/ContentCache.cpp during osx-10-10 debug testing → 11,600 instances of "'!IsSelectionValid()'" and associated warnings emitted from widget/ContentCache.cpp during debug testing
You need to log in before you can comment on or make changes to this bug.