1307282 - Remove global file-read-metadata rule and unused macros from OS X content sandbox

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Haik Aftandilian [:haik]]

This bug addresses a couple of low priority policy cleanup opportunities.

1) The content sandbox has the redundant rule (allow file-read-metadata) which allows reading of metadata for any file the user has access to. It's redundant because other rules, specifically the level 1 and 2 specific rules, setup the global filesystem access depending of the level. For example, for level 1 we allow read access to anywhere on the filesystem that the OS permits with 

  ; level 1: global read access permitted, no home write access
    (if (= sandbox-level 1)\n"
      (begin\n"
        (allow file-read*)\n"
        (allow file-write* (require-not (subpath home-path)))))

so having another rule allowing global file-read-metadata is error prone and confusing.

2) We can also remove these unused macros.

  (define (container-regex container-relative-regex) ...)
  (define (container-subpath container-relative-subpath) ...)
  (define (container-literal container-relative-literal) ...)
  (define (appdir-regex appdir-relative-regex) ...)
  (define (appdir-subpath appdir-relative-subpath) ...)
  (define (appdir-literal appdir-relative-literal) ...)

Comment 1

[Haik Aftandilian [:haik]]

Try results with just the (allow file-read-metadata) removed.

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ec42b81f875

Comment 2

[Haik Aftandilian [:haik]]

Attachment: Bug 1307282 - Remove unused sandbox ruleset macros;

Remove unused sandbox macros.

Review commit: https://reviewboard.mozilla.org/r/82900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82900/

Comment 3

[Haik Aftandilian [:haik]]

Attachment: Bug 1307282 - Remove redundant read-metadata rights from the content sandbox;

Remove redundant read-metadata rights from the content sandbox.

Review commit: https://reviewboard.mozilla.org/r/82902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82902/

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8797315 [details]
Bug 1307282 - Remove unused sandbox ruleset macros;

https://reviewboard.mozilla.org/r/82900/#review82892

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8797316 [details]
Bug 1307282 - Remove redundant read-metadata rights from the content sandbox;

https://reviewboard.mozilla.org/r/82902/#review82894

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Why do these two commits have identical commit messages?

Comment 7

[Haik Aftandilian [:haik]]

Comment on attachment 8797315 [details]
Bug 1307282 - Remove unused sandbox ruleset macros;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/82900/diff/1-2/

Comment 8

[Haik Aftandilian [:haik]]

Comment on attachment 8797316 [details]
Bug 1307282 - Remove redundant read-metadata rights from the content sandbox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/82902/diff/1-2/

Comment 9

[Haik Aftandilian [:haik]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> Why do these two commits have identical commit messages?

Fixed. Sorry, didn't realize that was a problem. Both commit messages had the same first line and differentiating second lines.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a7e549e1e91
Remove unused sandbox ruleset macros; r=gcp
https://hg.mozilla.org/integration/autoland/rev/e80c8083d933
Remove redundant read-metadata rights from the content sandbox; r=gcp

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a7e549e1e91
https://hg.mozilla.org/mozilla-central/rev/e80c8083d933