Closed Bug 1307361 Opened 4 years ago Closed 4 years ago

OOM message from heap checking zeal mode causes problems for differential fuzz testing

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox-esr45 --- unaffected
firefox50 --- affected
firefox51 --- affected
firefox52 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

From gkw:

> Bug 1272604 [1] introduced this changeset [2] that has the "OOM checking heap" message when certain conditions are met. This causes issues with differential testing - do you think we can ignore this message in deterministic builds (which we use for differential testing)? 

I think we should suppress this message in deterministic builds.
Summary: SOOM message from heap checking zeal mode causes problems for differential fuzz testing → OOM message from heap checking zeal mode causes problems for differential fuzz testing
Thanks! This will be NPOTB, so can probably be backported easily.
Actually we should just make this best-effort and abort the check if we hit OOM.
Assignee: nobody → jcoppeard
Attachment #8797543 - Flags: review?(sphink)
Attachment #8797543 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/884149c8dbc2
Remove OOM message in heap checking zeal mode r=sfink
https://hg.mozilla.org/mozilla-central/rev/884149c8dbc2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1315946
You need to log in before you can comment on or make changes to this bug.