Closed
Bug 1307363
Opened 6 years ago
Closed 6 years ago
Port Bug 890156 (Support per-monitor DPI on Windows 8.1 & 10 desktop) to thunderbird
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 52.0
People
(Reporter: m_kato, Assigned: Paenglab)
References
Details
Attachments
(1 file)
2.18 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Port https://bug890156.bmoattachments.org/attachment.cgi?id=8706362 to Thunderbird to support per monitor DPI on Windows.
Comment 1•6 years ago
|
||
Perhaps something for Richard.
Assignee | ||
Comment 2•6 years ago
|
||
Yes, I had this change since it's landing on radar. But without possibility of testing I didn't port it. But it's a minimal change.
Comment 3•6 years ago
|
||
Comment on attachment 8797443 [details] [diff] [review] bug1307363.patch Review of attachment 8797443 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/aboutDialog.css @@ +6,5 @@ > width: 620px; > + /* Set an explicit line-height to avoid discrepancies in 'auto' spacing > + across screens with different device DPI, which may cause font metrics > + to round differently. */ > + line-height: 1.5; That's not ported. Can you please explain. Have you tested that? I only have an old 1280x1024 screen, so no way for me to test.
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #3) > Comment on attachment 8797443 [details] [diff] [review] > bug1307363.patch > > Review of attachment 8797443 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/base/content/aboutDialog.css > @@ +6,5 @@ > > width: 620px; > > + /* Set an explicit line-height to avoid discrepancies in 'auto' spacing > > + across screens with different device DPI, which may cause font metrics > > + to round differently. */ > > + line-height: 1.5; > > That's not ported. Can you please explain. Have you tested that? I only have > an old 1280x1024 screen, so no way for me to test. This is also from bug 890156: https://hg.mozilla.org/mozilla-central/rev/1be1d936e2a2 . There a lot of changesets in this bug.
Assignee | ||
Comment 5•6 years ago
|
||
And the new comment in aboutDialog.css should explain why this is needed.
Comment 6•6 years ago
|
||
Comment on attachment 8797443 [details] [diff] [review] bug1307363.patch I assume you scanned all the changesets of bug 890156 and didn't find more changes needing to be ported.
Attachment #8797443 -
Flags: review?(jorgk) → review+
Assignee | ||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9233be0faf407d84fa47c14db8e70d8e1002913b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in
before you can comment on or make changes to this bug.
Description
•