Closed Bug 1307415 Opened 9 years ago Closed 9 years ago

Intermittent dom/url/tests/test_worker_url.html | Test timed out.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: baku)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Andrea, can you investigate this? Its the top intermittent at the moment.
Flags: needinfo?(amarchesini)
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
:baku, can you update your status on this? this is the most frequent failure in the last couple weeks- with no updates in the bug, I can only assume you cannot figure it out or you have forgotten about it. Do chime in if you need help in someway or there is more information on when we expect this to get fixed.
Flags: needinfo?(amarchesini)
baku has been working on this and was using rr to debug it when I last spoke with him before he went on PTO for a few days.
Attached patch text_fix.patchSplinter Review
We must update mFrozen correctly before being interrupted by the JS engine.
Flags: needinfo?(amarchesini)
Attachment #8804699 - Flags: review?(bkelly)
Comment on attachment 8804699 [details] [diff] [review] text_fix.patch Review of attachment 8804699 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/WorkerPrivate.cpp @@ +2663,5 @@ > > EnableDebugger(); > > + RefPtr<ThawRunnable> runnable = > + new ThawRunnable(ParentAsWorkerPrivate()); Could you explain how moving where we dispatch the ThawRunnable fixes the issue? I don't understand all the implications here.
Attachment #8804699 - Flags: review?(bkelly)
This bug has been fixed by the new event queue in workers.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: