Closed Bug 1307435 Opened 3 years ago Closed 3 years ago

Easy symbol generation optimization improvements

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(2 files)

First part of work for bug 1307301.
ted: feel free to autoland if you r+, as I'll be on a plane later
Comment on attachment 8797600 [details]
Bug 1307435 - Generate symbols zip file concurrently;

https://reviewboard.mozilla.org/r/83274/#review85146

This seems like a straightforward win for the short-term. Longer-term maybe we should move the zip file generation into the Python script?

::: Makefile.in:331
(Diff revision 1)
>  	$(NSINSTALL) -D $(DIST)/$(PKG_PATH)
> +endif # MOZ_CRASHREPORTER
> +
> +.PHONY: symbolsfullarchive
> +symbolsfullarchive: generatesymbols
> +ifdef MOZ_CRASHREPORTER

Maybe you should just wrap these whole targets in the ifdef, and then have like:
```
ifdef MOZ_CRASHREPORTER:
buildsymbols: symbolsfullarchive symbolsarchive
else
buildsymbols:
endif
```
Attachment #8797600 - Flags: review?(ted) → review+
Comment on attachment 8797601 [details]
Bug 1307435 - Change compression level of symbols files;

https://reviewboard.mozilla.org/r/83276/#review85148

Might be useful to look at tweaking the tar.bz2 generation in the OS X case. I know you've looked at the Windows PDB compression bit in the past.
Attachment #8797601 - Flags: review?(ted) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a4b248fce1f
Generate symbols zip file concurrently; r=ted
https://hg.mozilla.org/integration/autoland/rev/7cd613179479
Change compression level of symbols files; r=ted
https://hg.mozilla.org/mozilla-central/rev/5a4b248fce1f
https://hg.mozilla.org/mozilla-central/rev/7cd613179479
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.