1307448 - files that are effectively renamed are showed as deleted/new

Status: RESOLVED WONTFIX

(MozReview Graveyard :: Integration: Mercurial, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

a frustrating review experience:
https://reviewboard.mozilla.org/r/82058/diff/3/

Comment 1

[Mark Côté [:mcote]]

Attachment: File renames in Phabricator-Differential

FYI Phabricator appears to handle proper renames (that is, with "hg mv") correctly; see attached screenshot.

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to Mark Côté [:mcote] from comment #1)
> Created attachment 8872782 [details]
> File renames in Phabricator-Differential
> 
> FYI Phabricator appears to handle proper renames (that is, with "hg mv")
> correctly; see attached screenshot.

So does Review Board, the linked review request was due to "hg mv" not being used. I wonder what phabricator shows in that case? I'm guessing probably a delete and add like Review Board.

Comment 3

[Gregory Szorc [:gps]]

(In reply to Steven MacLeod [:smacleod] from comment #2)
> So does Review Board, the linked review request was due to "hg mv" not being
> used. I wonder what phabricator shows in that case? I'm guessing probably a
> delete and add like Review Board.

I would guess this too. But Phabricator has reinvented enough aspects of version control that I wouldn't be surprised if they do copy and rename detection. Although it only has access to the files touched by the commit, so it can't detect copies from unmodified files like git's --find-copies-harder can.

Comment 4

[Mark Côté [:mcote]]

Ah I see.  Yeah, it shows the same as Review Board.  I believe this is technically correct, since, as you imply, "hg mv X Y" is technically different from "cp X Y; hg rm X; hg add Y".  Due to the fact that these are, for whatever reason, different operations in hg, I'm WONTFIXing this.  I think reviewers should r- a patch that should use "hg mv" but doesn't.