Closed Bug 1307461 Opened 3 years ago Closed 3 years ago

Intermittent mediapipeline_unittest | test failed with return code 1 due to MediaPipelineTest.TestAudioSendMux failure

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- wontfix
firefox52 --- disabled
firefox-esr52 --- fixed
firefox53 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dminor)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=3734995&repo=mozilla-aurora

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-aurora-linux-pgo/1475547840/mozilla-aurora_ubuntu32_vm_test_pgo-cppunit-bm05-tests1-linux32-build2.txt.gz

[ RUN      ] MediaPipelineTest.TestAudioSendMux
/builds/slave/m-aurora-lx-000000000000000000/build/src/media/webrtc/signaling/test/mediapipeline_unittest.cpp:453: Failure
Value of: p2_.GetAudioRtpCountReceived()
  Actual: 233
Expected: p1_.GetAudioRtpCountSent()
Which is: 970
[  FAILED  ] MediaPipelineTest.TestAudioSendMux (11146 ms)
Not sure this is a great check as written.
Rank: 25
Priority: -- → P2
We stopped building this test on trunk via bug 1322707. However, 52 continues to be affected (and is destined to be our next ESR).
Status: NEW → RESOLVED
Closed: 3 years ago
Depends on: 1322707
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
If disabling the entire test isn't desirable, can we maybe skip just the one problematic subtest?
Flags: needinfo?(rjesup)
Dan, can you look at this?  thanks
Flags: needinfo?(rjesup) → needinfo?(dminor)
Attachment #8831749 - Flags: review?(rjesup) → review+
Comment on attachment 8831749 [details] [diff] [review]
Disable TestAudioSendMux

Approval Request Comment
[Feature/Bug causing the regression]: Not sure, we're working around an intermittent failure.
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: This test is completely disabled in aurora and nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: We're disabling an intermittent test. There is a slight risk that we could introduce a regression that this test would have caught, but since this test is disabled on aurora and currently disabled on nightly while it is being rewrittent, I think we're ok with that risk.
[String changes made/needed]: None
Attachment #8831749 - Flags: approval-mozilla-beta?
Comment on attachment 8831749 [details] [diff] [review]
Disable TestAudioSendMux

test-only changes don't need approval, thanks Dan!
Attachment #8831749 - Flags: approval-mozilla-beta?
Whiteboard: [checkin-needed-beta]
Bah, it just moved to TestAudioSendNoMux. Guess that's not surprising given bug 1317044, in retrospect.
https://treeherder.mozilla.org/logviewer.html#?job_id=73368952&repo=mozilla-beta
Assignee: nobody → dminor
Flags: needinfo?(dminor)
Attached patch whack-a-moleSplinter Review
If we see any more problems after this, I'll just disable the test completely.
Flags: needinfo?(dminor)
Attachment #8832505 - Flags: review?(rjesup)
Attachment #8832505 - Flags: review?(rjesup) → review+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: checkin-needed-beta
Bug resolution tracks status on trunk.
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed-beta
Just disable the test completely. Ryan said he would be willing to take the gtest version of this test once it is ready if it ends up being less prone to intermittent failures.
Flags: needinfo?(dminor)
Attachment #8835499 - Flags: review?(rjesup)
Attachment #8835499 - Flags: review?(rjesup) → review+
Whiteboard: checkin-needed-beta
You need to log in before you can comment on or make changes to this bug.