1307464 - MIgrate the shader editor tooltip to HTML tooltip

Status: RESOLVED FIXED

(DevTools Graveyard :: WebGL Shader Editor, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

The work required for this bug is to migrate the shader editor tooltip to HTML tooltip and then move the XUL tooltip to the debugger module. This way it would no longer pollute the widgets folder and would be removed automatically when the old debugger gets removed.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

needinfo'd you julian in case you wanted to take it. I don't have the necessary bandwidth to work on this at the moment.

Comment 2

[Julian Descottes [:jdescottes]]

Sure, thanks for logging it!

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1307464 - Use HTMLTooltip in shader editor;

Migrate the ShaderEditor to use the HTMLTooltip instead of the
old XUL-only Tooltip. The HTMLTooltip doesn't provide a builtin
setTextContent API, so the shadereditor is now creating the
markup for the tooltip and setting it as the content.

The styles have been ported to shadereditor.css and now rely on
theme variables.

This will allow us to move all the old tooltip code to the old
debugger folder, which will be the last consumer of the widget.

Review commit: https://reviewboard.mozilla.org/r/259884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259884/

Comment 5

[Julian Descottes [:jdescottes]]

How to test this:
- go to any WebGL demo site (eg http://alteredqualia.com/three/examples/webgl_pasta.html)
- open Shader Editor
- click on reload button in the Shader Editor
- delete some random code in text editor to trigger errors
- hover on the error icons appearing in the gutter

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: shader_editor_html_tooltip.png

Here is a screenshot of the new tooltip in dark theme.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: shader_editor_html_tooltip_light.png

Same in light theme

Comment 8

[Julian Descottes [:jdescottes]]

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=60da09f6a76bf7d63a4ea9d3b10e5749f0d9d32c

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8995435 [details]
Bug 1307464 - Use HTMLTooltip in shader editor;

https://reviewboard.mozilla.org/r/259884/#review266892

That looks good to me ! (and now I'm hungry with all those pastas flying around :) )
Thanks Julian

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7039031e380
Use HTMLTooltip in shader editor;r=nchevobbe

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d7039031e380